Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2889553002: Revert of Use TaskScheduler instead of SequencedWorkerPool in snapshot_cache.mm. (Closed)

Created:
3 years, 7 months ago by kolos1
Modified:
3 years, 7 months ago
Reviewers:
jif, fdoray
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskScheduler instead of SequencedWorkerPool in snapshot_cache.mm. (patchset #2 id:20001 of https://codereview.chromium.org/2881873002/ ) Reason for revert: Probably this CL causes many failures of iOS bots. For example, https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/17573 Original issue's description: > Use TaskScheduler instead of SequencedWorkerPool in snapshot_cache.mm. > > SequencedWorkerPool is being deprecated in favor of TaskScheduler. > > BUG=667892 > R=jif@chromium.org > > Review-Url: https://codereview.chromium.org/2881873002 > Cr-Commit-Position: refs/heads/master@{#472052} > Committed: https://chromium.googlesource.com/chromium/src/+/aa5299ae23a57ca5dce00a11da3ac8e73849351f TBR=jif@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667892 Review-Url: https://codereview.chromium.org/2889553002 Cr-Commit-Position: refs/heads/master@{#472065} Committed: https://chromium.googlesource.com/chromium/src/+/fb580dd729ddfbd6729c8ba416f8b6f2d474a44b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M ios/chrome/browser/snapshots/snapshot_cache.mm View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kolos1
Created Revert of Use TaskScheduler instead of SequencedWorkerPool in snapshot_cache.mm.
3 years, 7 months ago (2017-05-16 12:19:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889553002/1
3 years, 7 months ago (2017-05-16 12:19:59 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 12:20:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb580dd729ddfbd6729c8ba416f8...

Powered by Google App Engine
This is Rietveld 408576698