MutationObserver: Correct MutationRecords for Node.replaceChild().

MutationObserver: Correct MutationRecords for Node.replaceChild().

  parent.replaceChild(parent.lastChild, parent.firstChild);

This code produced just one MutationRecord, but it should produce two
MutationRecords. This CL makes replaceChild() implementation close to the DOM
standard.

New behavior matches to Firefox and Safari.

BUG=722741
Review-Url: https://codereview.chromium.org/2889523002
Cr-Commit-Position: refs/heads/master@{#472393}
Committed: https://chromium.googlesource.com/chromium/src/+/56387aa57bc11d0f969c5bb9824a39c804202be3

[tkent, 2017-05-16 08:27:56]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 08:28:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-05-16 09:03:17]

Description was changed from

==========
MutationObserver: Correct MutationRecords for Node.repalceChild().

  parent.replaceChild(parent.lastChild, parent.firstChild);

This code produced just one MutationRecord, but it should produce two
MutationRecoards. This CL makes replaceChild() implementation close to the DOM
standard.

BUG=722741
==========

to

==========
MutationObserver: Correct MutationRecords for Node.repalceChild().

  parent.replaceChild(parent.lastChild, parent.firstChild);

This code produced just one MutationRecord, but it should produce two
MutationRecoards. This CL makes replaceChild() implementation close to the DOM
standard.

New behavior matches to Firefox and Safari.

BUG=722741
==========

[commit-bot: I haz the power, 2017-05-16 09:32:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 09:32:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-05-17 00:34:24]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 00:36:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-05-17 00:50:43]

Patchset #1 (id:1) has been deleted

[tkent, 2017-05-17 00:54:22]

Description was changed from

==========
MutationObserver: Correct MutationRecords for Node.repalceChild().

  parent.replaceChild(parent.lastChild, parent.firstChild);

This code produced just one MutationRecord, but it should produce two
MutationRecoards. This CL makes replaceChild() implementation close to the DOM
standard.

New behavior matches to Firefox and Safari.

BUG=722741
==========

to

==========
MutationObserver: Correct MutationRecords for Node.repalceChild().

  parent.replaceChild(parent.lastChild, parent.firstChild);

This code produced just one MutationRecord, but it should produce two
MutationRecords. This CL makes replaceChild() implementation close to the DOM
standard.

New behavior matches to Firefox and Safari.

BUG=722741
==========

[tkent, 2017-05-17 01:57:03]

tkent@chromium.org changed reviewers:
+ hayato@chromium.org

[tkent, 2017-05-17 01:57:04]

hayato@, would you review this please?

[commit-bot: I haz the power, 2017-05-17 02:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 02:27:25]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[hayato, 2017-05-17 04:56:13]

LGTM

Nit: Could we add a comment which explains where step 13, 14 happen? It might
not be obvious from the code.

[tkent, 2017-05-17 05:13:45]

> Nit: Could we add a comment which explains where step 13, 14 happen? It might
not be obvious from the code.

Ok, I added step comments as much as possible in Patch Set 2.

[tkent, 2017-05-17 05:13:55]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-05-17 05:13:56]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/2889523002/#ps40001
(title: "Add step comments")

[commit-bot: I haz the power, 2017-05-17 05:14:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-05-17 06:16:10]

unmutate :) the title before landing (s/repalce/replace/)?

[tkent, 2017-05-17 07:23:08]

Description was changed from

==========
MutationObserver: Correct MutationRecords for Node.repalceChild().

  parent.replaceChild(parent.lastChild, parent.firstChild);

This code produced just one MutationRecord, but it should produce two
MutationRecords. This CL makes replaceChild() implementation close to the DOM
standard.

New behavior matches to Firefox and Safari.

BUG=722741
==========

to

==========
MutationObserver: Correct MutationRecords for Node.replaceChild().

  parent.replaceChild(parent.lastChild, parent.firstChild);

This code produced just one MutationRecord, but it should produce two
MutationRecords. This CL makes replaceChild() implementation close to the DOM
standard.

New behavior matches to Firefox and Safari.

BUG=722741
==========

[tkent, 2017-05-17 07:23:34]

On 2017/05/17 at 06:16:10, sigbjornf wrote:
> unmutate :) the title before landing (s/repalce/replace/)?

Done.  Thanks!

[commit-bot: I haz the power, 2017-05-17 09:13:27]

Description was changed from

==========
MutationObserver: Correct MutationRecords for Node.replaceChild().

  parent.replaceChild(parent.lastChild, parent.firstChild);

This code produced just one MutationRecord, but it should produce two
MutationRecords. This CL makes replaceChild() implementation close to the DOM
standard.

New behavior matches to Firefox and Safari.

BUG=722741
==========

to

==========
MutationObserver: Correct MutationRecords for Node.replaceChild().

  parent.replaceChild(parent.lastChild, parent.firstChild);

This code produced just one MutationRecord, but it should produce two
MutationRecords. This CL makes replaceChild() implementation close to the DOM
standard.

New behavior matches to Firefox and Safari.

BUG=722741

Review-Url: https://codereview.chromium.org/2889523002
Cr-Commit-Position: refs/heads/master@{#472393}
Committed:
https://chromium.googlesource.com/chromium/src/+/56387aa57bc11d0f969c5bb9824a...
==========

[commit-bot: I haz the power, 2017-05-17 09:13:28]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/56387aa57bc11d0f969c5bb9824a...