chrome/browser/resources/settings/settings_shared_css.html - Issue 2889493002: [MD settings] removing secondary-button class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2889493002: [MD settings] removing secondary-button class (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_page/search_page.html ('k') | chrome/browser/resources/settings/site_settings/site_data.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_shared_css.html

diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html

index fdbd1d2d761e3997324d2455776aefdb9bb12228..f3d1b1870d1083620dedfd0868bc5cbb790f7315 100644

--- a/chrome/browser/resources/settings/settings_shared_css.html

+++ b/chrome/browser/resources/settings/settings_shared_css.html

@@ -78,11 +78,24 @@

color: inherit !important;

}

- /* There are three main button styles, .primary-button, .secondary-button,

- * and .tertiary-button. The primary is the action button (e.g. "edit",

- * "delete") while the secondary is often a "Cancel" button. A tertiary

- * button may be used to get more information or similar, that we expect

- * most users will not need. */

+ /* See notes in .primary-button. */

+ paper-button {

+ --paper-button: {

+ -webkit-padding-end: var(--settings-button-edge-spacing);

+ -webkit-padding-start: var(--settings-button-edge-spacing);

+ color: var(--paper-grey-600);

+ font-weight: 500;

+ min-width: 1em; /* A tighter fit than 5.14em for short buttons. */

+ text-decoration: none;

+ };

+ --paper-button-flat-keyboard-focus: {

+ background: rgba(0, 0, 0, .12);

+ };

+ }

+ /* There are two settings button styles, .primary-button and normal

+ * buttons. The primary is the action button (e.g. "edit", "delete")

+ * while the normal (secondary-button) is often a "Cancel" button. */

.primary-button {

--paper-button: {

-webkit-padding-end: var(--settings-button-edge-spacing);

@@ -101,23 +114,7 @@

color: var(--google-blue-500);

}

- /* See notes in .primary-button. */

- .secondary-button {

- --paper-button: {

- -webkit-padding-end: var(--settings-button-edge-spacing);

- -webkit-padding-start: var(--settings-button-edge-spacing);

- color: var(--paper-grey-600);

- font-weight: 500;

- min-width: 1em; /* A tighter fit than 5.14em for short buttons. */

- text-decoration: none;

- };

- --paper-button-flat-keyboard-focus: {

- background: rgba(0, 0, 0, .12);

- };

- }

- .settings-box .primary-button,

- .settings-box .secondary-button {

+ .settings-box paper-button {

-webkit-margin-end: calc(var(--settings-button-edge-spacing) * -1);

-webkit-margin-start: calc(var(--settings-button-edge-spacing) * -1);

}