[MD settings] removing secondary-button class

chrome/browser/resources/settings/settings_shared_css.html

 <link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
 <link rel="import" href="settings_vars_css.html">
 
 <!-- Common styles for Material Design settings. -->
 <dom-module id="settings-shared">
   <template>
     <style include="cr-shared-style">
       :host-context([dir=rtl]) button[is='paper-icon-button-light'] {
         transform: scaleX(-1);  /* Flip on the X axis (aka mirror). */
       }
@@ skipping 21 matching lines @@
 
       iron-icon[icon='cr:check'],
       iron-icon[icon='settings:done'] {
        --iron-icon-fill-color: var(--google-green-500);
       }
 
       paper-button {
         flex-shrink: 0;
         height: 36px;
         margin: 0;
       }

[stevenjb, 2017/05/16 16:27:29]

Can we merge this with the other paper-button CSS?

[dschuyler, 2017/05/16 19:07:56]

Done.

 
       paper-button[toggles][active] {
         background-color: var(--paper-grey-300);
       }

[stevenjb, 2017/05/16 16:27:29]

And maybe move this down also (or move the rest up here)?

[dschuyler, 2017/05/16 19:07:56]

Done.

 
       paper-toggle-button {
         @apply(--settings-actionable);
         height: var(--settings-row-min-height);
         width: 36px;
       }
 
       span ~ a {
         -webkit-margin-start: 4px;
       }
 
       .primary-button {
         color: var(--google-blue-500);
       }

[stevenjb, 2017/05/16 16:27:29]

Ditto

[dschuyler, 2017/05/16 19:07:56]

Done.

 
       a[href] {
         color: var(--google-blue-700);
       }
 
       .primary-button {
         --paper-button-flat-keyboard-focus: {
           background: rgba(51, 103, 214, .12);  /* --google-blue-700 */
         };
       }

[stevenjb, 2017/05/16 16:27:29]

Ditto

[dschuyler, 2017/05/16 19:07:56]

Done.

 
       a[href] {
         text-decoration: none;
       }
 
       /* For elements that are simple out-links but don't look like anchors. */
       .inherit-color {
         color: inherit !important;
       }
 
-      /* There are three main button styles, .primary-button, .secondary-button,
-       * and .tertiary-button. The primary is the action button (e.g. "edit",
-       * "delete") while the secondary is often a "Cancel" button. A tertiary
-       * button may be used to get more information or similar, that we expect
-       * most users will not need. */
+      /* See notes in .primary-button. */
+      paper-button {
+        --paper-button: {
+          -webkit-padding-end: var(--settings-button-edge-spacing);
+          -webkit-padding-start: var(--settings-button-edge-spacing);
+          color: var(--paper-grey-600);
+          font-weight: 500;
+          min-width: 1em;  /* A tighter fit than 5.14em for short buttons. */
+          text-decoration: none;
+        };
+        --paper-button-flat-keyboard-focus: {
+          background: rgba(0, 0, 0, .12);
+        };
+      }
+
+      /* There are two settings button styles, .primary-button and normal
+       * buttons. The primary is the action button (e.g. "edit", "delete")
+       * while the normal (secondary-button) is often a "Cancel" button. */
       .primary-button {
         --paper-button: {
           -webkit-padding-end: var(--settings-button-edge-spacing);
           -webkit-padding-start: var(--settings-button-edge-spacing);

[stevenjb, 2017/05/16 16:27:29]

Same as for paper-button (and therefor not needed)?

[dschuyler, 2017/05/16 19:07:56]

This is in a mixin variable. So it must be a complete set of styles. i.e. this
is not like += it's more like = it that it overwrites the prior value.

[stevenjb, 2017/05/16 19:22:11]

Ah, right. Might be worth defining a var for these, but maybe not. Up to you.

           font-weight: 500;

[stevenjb, 2017/05/16 16:27:29]

ditto?

[dschuyler, 2017/05/16 19:07:56]

intractable.

           text-align: start;
         };
       }
 
       .primary-toggle {
         color: var(--paper-grey-600);
         font-weight: 500;
       }
 
       .primary-toggle[checked] {
         color: var(--google-blue-500);
       }
 
-      /* See notes in .primary-button. */
-      .secondary-button {
-        --paper-button: {
-          -webkit-padding-end: var(--settings-button-edge-spacing);
-          -webkit-padding-start: var(--settings-button-edge-spacing);
-          color: var(--paper-grey-600);
-          font-weight: 500;
-          min-width: 1em;  /* A tighter fit than 5.14em for short buttons. */
-          text-decoration: none;
-        };
-        --paper-button-flat-keyboard-focus: {
-          background: rgba(0, 0, 0, .12);
-        };
-      }
-
-      .settings-box .primary-button,
-      .settings-box .secondary-button {
+      .settings-box paper-button {
         -webkit-margin-end: calc(var(--settings-button-edge-spacing) * -1);
         -webkit-margin-start: calc(var(--settings-button-edge-spacing) * -1);
       }
 
       paper-checkbox {
         --paper-checkbox-checked-color: var(--google-blue-500);
         --paper-checkbox-label-spacing: var(--settings-control-spacing);
         --paper-checkbox-size: var(--checkbox-size);
         --paper-checkbox-unchecked-color: var(--paper-grey-600);
         -webkit-margin-start: var(--checkbox-margin-start);
@@ skipping 277 matching lines @@
         transform: rotate(-135deg);
       }
 
       .column-header {
         color: var(--paper-grey-600);
         font-weight: 500;
       }
     </style>
   </template>
 </dom-module>