Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: pkg/front_end/lib/src/incremental/file_state.dart

Issue 2889463002: Fixes for review comments. (Closed)
Patch Set: Fixes and tweaks. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/incremental/file_state.dart
diff --git a/pkg/front_end/lib/src/incremental/file_state.dart b/pkg/front_end/lib/src/incremental/file_state.dart
index 183ef202a5138b7ddcf3b7dfc6681793e5f2a4c9..dcd43fb9d3b545caa0f24fbfda5cdb54fbcf3e66 100644
--- a/pkg/front_end/lib/src/incremental/file_state.dart
+++ b/pkg/front_end/lib/src/incremental/file_state.dart
@@ -135,14 +135,14 @@ class FileState {
_importedLibraries.add(coreFile);
}
}
- for (ImportDirective import_ in listener.imports) {
+ for (NamespaceDirective import_ in listener.imports) {
FileState file = await _getFileForRelativeUri(import_.uri);
if (file != null) {
_importedLibraries.add(file);
}
}
await _addVmTargetImportsForCore();
- for (ExportDirective export_ in listener.exports) {
+ for (NamespaceDirective export_ in listener.exports) {
FileState file = await _getFileForRelativeUri(export_.uri);
if (file != null) {
_exportedLibraries.add(file);
@@ -287,7 +287,7 @@ class NamespaceExport {
NamespaceExport(this.library, this.combinators);
/// Return `true` if the [name] satisfies the sequence of the [combinators].
- bool filter(String name) {
+ bool isExposed(String name) {
for (NamespaceCombinator combinator in combinators) {
if (combinator.isShow) {
if (!combinator.names.contains(name)) {
« no previous file with comments | « pkg/front_end/lib/src/fasta/source/directive_listener.dart ('k') | pkg/front_end/test/src/incremental/file_state_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698