Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: pkg/front_end/test/src/incremental/file_state_test.dart

Issue 2889463002: Fixes for review comments. (Closed)
Patch Set: Fixes and tweaks. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/incremental/file_state.dart ('k') | pkg/front_end/tool/fasta_perf.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/test/src/incremental/file_state_test.dart
diff --git a/pkg/front_end/test/src/incremental/file_state_test.dart b/pkg/front_end/test/src/incremental/file_state_test.dart
index bd2fcab49cebb171aa07fa274c78b58c7704a741..00c3707ac97283f25592a120f992382b94579fa2 100644
--- a/pkg/front_end/test/src/incremental/file_state_test.dart
+++ b/pkg/front_end/test/src/incremental/file_state_test.dart
@@ -93,10 +93,10 @@ export "c.dart" show A, B, C, D hide C show A, D;
expect(export_.combinators, hasLength(1));
expect(export_.combinators[0].isShow, isTrue);
expect(export_.combinators[0].names, unorderedEquals(['A', 'B']));
- expect(export_.filter('A'), isTrue);
- expect(export_.filter('B'), isTrue);
- expect(export_.filter('C'), isFalse);
- expect(export_.filter('D'), isFalse);
+ expect(export_.isExposed('A'), isTrue);
+ expect(export_.isExposed('B'), isTrue);
+ expect(export_.isExposed('C'), isFalse);
+ expect(export_.isExposed('D'), isFalse);
}
{
NamespaceExport export_ = dFile.exports[1];
@@ -104,10 +104,10 @@ export "c.dart" show A, B, C, D hide C show A, D;
expect(export_.combinators, hasLength(1));
expect(export_.combinators[0].isShow, isFalse);
expect(export_.combinators[0].names, unorderedEquals(['C', 'D']));
- expect(export_.filter('A'), isTrue);
- expect(export_.filter('B'), isTrue);
- expect(export_.filter('C'), isFalse);
- expect(export_.filter('D'), isFalse);
+ expect(export_.isExposed('A'), isTrue);
+ expect(export_.isExposed('B'), isTrue);
+ expect(export_.isExposed('C'), isFalse);
+ expect(export_.isExposed('D'), isFalse);
}
{
NamespaceExport export_ = dFile.exports[2];
@@ -120,10 +120,10 @@ export "c.dart" show A, B, C, D hide C show A, D;
expect(export_.combinators[1].names, unorderedEquals(['C']));
expect(export_.combinators[2].isShow, isTrue);
expect(export_.combinators[2].names, unorderedEquals(['A', 'D']));
- expect(export_.filter('A'), isTrue);
- expect(export_.filter('B'), isFalse);
- expect(export_.filter('C'), isFalse);
- expect(export_.filter('D'), isTrue);
+ expect(export_.isExposed('A'), isTrue);
+ expect(export_.isExposed('B'), isFalse);
+ expect(export_.isExposed('C'), isFalse);
+ expect(export_.isExposed('D'), isTrue);
}
}
« no previous file with comments | « pkg/front_end/lib/src/incremental/file_state.dart ('k') | pkg/front_end/tool/fasta_perf.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698