Fixes for review comments.

Fixes for review comments.

R=sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/43cea08f6d1250b045ea8d1f466f58eb78b64e29

[Siggi Cherem (dart-lang), 2017-05-16 21:42:04]

lgtm, thanks!

https://codereview.chromium.org/2889463002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/directive_listener.dart (right):

https://codereview.chromium.org/2889463002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/directive_listener.dart:23: /// Export
directives with URIs and combinators.
Export => Import

https://codereview.chromium.org/2889463002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/directive_listener.dart:56: if (_combinators
!= null || _inPart) {
let's add a simple getter with this formula:

  bool _inDirective => _combinators != null || _inPart;

It's not needed, but it helps document our intent directly with a name in the
code. That will make the invariant of this listener a bit more self-explanatory
:)

https://codereview.chromium.org/2889463002/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental/file_state.dart (right):

https://codereview.chromium.org/2889463002/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:289: /// Return `true` if the
[name] satisfies the sequence of the [combinators].
consider updating the dartdoc to say that it is the equivalent of a name being
visible after applying the show/hide combinators.

[scheglov, 2017-05-17 00:07:31]

https://codereview.chromium.org/2889463002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/directive_listener.dart (right):

https://codereview.chromium.org/2889463002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/directive_listener.dart:23: /// Export
directives with URIs and combinators.
On 2017/05/16 21:42:04, Siggi Cherem (dart-lang) wrote:
> Export => Import 

Done.

https://codereview.chromium.org/2889463002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/directive_listener.dart:56: if (_combinators
!= null || _inPart) {
On 2017/05/16 21:42:04, Siggi Cherem (dart-lang) wrote:
> let's add a simple getter with this formula:
> 
>   bool _inDirective => _combinators != null || _inPart;
> 
> It's not needed, but it helps document our intent directly with a name in the
> code. That will make the invariant of this listener a bit more
self-explanatory
> :)

I think the class is small enough to make relations visible without additional
layers.

https://codereview.chromium.org/2889463002/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental/file_state.dart (right):

https://codereview.chromium.org/2889463002/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:289: /// Return `true` if the
[name] satisfies the sequence of the [combinators].
On 2017/05/16 21:42:04, Siggi Cherem (dart-lang) wrote:
> consider updating the dartdoc to say that it is the equivalent of a name being
> visible after applying the show/hide combinators.

Well, it's different way to say the same.
I'm not sure that it fixes a problem with the existing explanation.

[scheglov, 2017-05-17 00:27:45]

Description was changed from

==========
Fixes for review comments.

R=sigmund@google.com
BUG=
==========

to

==========
Fixes for review comments.

R=sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/43cea08f6d1250b045ea8d1f466f58eb78b64e29
==========

[scheglov, 2017-05-17 00:27:46]

Committed patchset #2 (id:20001) manually as
43cea08f6d1250b045ea8d1f466f58eb78b64e29 (presubmit successful).