[Payments] Use Autofill card assets for Payment Request

[Payments] Use Autofill card assets for Payment Request

* Desktop and iOS will use Autofill assets
* Android keeps using the drawables (vector)
* MIR card now has a border (fixes Autofill asset)

BUG=722651
TEST=visually tested on desktop, iOS
TBR=blundell

Review-Url: https://codereview.chromium.org/2889453004
Cr-Commit-Position: refs/heads/master@{#472311}
Committed: https://chromium.googlesource.com/chromium/src/+/daa7b93ee4630af1fd1f1f5176731c430be51e50

[Mathieu, 2017-05-16 01:45:31]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 01:46:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:53:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 01:53:07]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Mathieu, 2017-05-16 01:59:05]

Description was changed from

==========
[Payments] Use Autofill card assets for Payment Request

BUG=722651
TEST=visual
==========

to

==========
[Payments] Use Autofill card assets for Payment Request

* Desktop and iOS will use Autofill assets
* Android keeps using the drawables (vector)
* MIR card now has a border (fixes Autofill asset)

BUG=722651
TEST=visual
==========

[Mathieu, 2017-05-16 01:59:05]

mathp@chromium.org changed reviewers:
+ rouslan@chromium.org

[Mathieu, 2017-05-16 12:34:15]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 12:34:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 13:00:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 13:00:04]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Mathieu, 2017-05-16 13:30:16]

Patchset #3 (id:40001) has been deleted

[Mathieu, 2017-05-16 13:30:42]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 13:31:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 13:55:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 13:55:50]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Mathieu, 2017-05-16 14:03:32]

Patchset #3 (id:60001) has been deleted

[Mathieu, 2017-05-16 14:04:02]

Description was changed from

==========
[Payments] Use Autofill card assets for Payment Request

* Desktop and iOS will use Autofill assets
* Android keeps using the drawables (vector)
* MIR card now has a border (fixes Autofill asset)

BUG=722651
TEST=visual
==========

to

==========
[Payments] Use Autofill card assets for Payment Request

* Desktop and iOS will use Autofill assets
* Android keeps using the drawables (vector)
* MIR card now has a border (fixes Autofill asset)

BUG=722651
TEST=visually tested on desktop, iOS
==========

[Mathieu, 2017-05-16 14:04:15]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 14:04:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-05-16 14:12:04]

Rouslan PTAL

[commit-bot: I haz the power, 2017-05-16 14:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 14:52:26]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-05-16 14:53:39]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-05-16 14:53:41]

The CQ bit was unchecked by rouslan@chromium.org

[please use gerrit instead, 2017-05-16 14:53:48]

lgtm

https://codereview.chromium.org/2889453004/diff/80001/components/autofill/cor...
File components/autofill/core/browser/autofill_data_util.cc (right):

https://codereview.chromium.org/2889453004/diff/80001/components/autofill/cor...
components/autofill/core/browser/autofill_data_util.cc:29: // On Android, use
the PR-specific resource IDs.
Do we plan to bring the goodies to Android eventually?

[Mathieu, 2017-05-16 15:01:37]

Now with different AMEX icon!

https://codereview.chromium.org/2889453004/diff/80001/components/autofill/cor...
File components/autofill/core/browser/autofill_data_util.cc (right):

https://codereview.chromium.org/2889453004/diff/80001/components/autofill/cor...
components/autofill/core/browser/autofill_data_util.cc:29: // On Android, use
the PR-specific resource IDs.
On 2017/05/16 14:53:48, ಠ_ಠ wrote:
> Do we plan to bring the goodies to Android eventually?

We can assess whether we want to keep vectors there. My understanding is that
you can get into very high DPI on android, so may need to keep vectors.

[Mathieu, 2017-05-16 15:40:58]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-05-16 15:40:59]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2889453004/#ps100001
(title: "different amex icon")

[Mathieu, 2017-05-16 15:41:02]

The CQ bit was unchecked by mathp@chromium.org

[Mathieu, 2017-05-16 23:54:15]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:55:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 00:17:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 00:17:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mathieu, 2017-05-17 00:35:31]

Description was changed from

==========
[Payments] Use Autofill card assets for Payment Request

* Desktop and iOS will use Autofill assets
* Android keeps using the drawables (vector)
* MIR card now has a border (fixes Autofill asset)

BUG=722651
TEST=visually tested on desktop, iOS
==========

to

==========
[Payments] Use Autofill card assets for Payment Request

* Desktop and iOS will use Autofill assets
* Android keeps using the drawables (vector)
* MIR card now has a border (fixes Autofill asset)

BUG=722651
TEST=visually tested on desktop, iOS
TBR=blundell
==========

[Mathieu, 2017-05-17 00:35:31]

mathp@chromium.org changed reviewers:
+ blundell@chromium.org

[Mathieu, 2017-05-17 00:35:47]

TBR blundell for removal of assets

[Mathieu, 2017-05-17 00:35:56]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2017-05-17 00:38:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 03:50:47]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494981356481280,
"parent_rev": "0e449e0fcf8527caa1a500a471422242894a7760", "commit_rev":
"daa7b93ee4630af1fd1f1f5176731c430be51e50"}

[commit-bot: I haz the power, 2017-05-17 03:51:01]

Description was changed from

==========
[Payments] Use Autofill card assets for Payment Request

* Desktop and iOS will use Autofill assets
* Android keeps using the drawables (vector)
* MIR card now has a border (fixes Autofill asset)

BUG=722651
TEST=visually tested on desktop, iOS
TBR=blundell
==========

to

==========
[Payments] Use Autofill card assets for Payment Request

* Desktop and iOS will use Autofill assets
* Android keeps using the drawables (vector)
* MIR card now has a border (fixes Autofill asset)

BUG=722651
TEST=visually tested on desktop, iOS
TBR=blundell

Review-Url: https://codereview.chromium.org/2889453004
Cr-Commit-Position: refs/heads/master@{#472311}
Committed:
https://chromium.googlesource.com/chromium/src/+/daa7b93ee4630af1fd1f1f517673...
==========

[commit-bot: I haz the power, 2017-05-17 03:51:02]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/daa7b93ee4630af1fd1f1f517673...

[blundell, 2017-05-17 09:03:44]

rs lgtm

[blundell, 2017-05-17 09:04:31]

https://codereview.chromium.org/2889453004/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/payments/payment_request_views_util.cc (left):

https://codereview.chromium.org/2889453004/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/payments/payment_request_views_util.cc:249:
card_icon_view->SetBorder(views::CreateRoundedRectBorder(
are you sure that there shouldn't be a corresponding //ios/chrome change?