Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Unified Diff: components/offline_pages/core/prefetch/prefetch_request_fetcher.cc

Issue 2889453003: [Offline Prefetech] Send GetOperationReqest to the server (Closed)
Patch Set: Address feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/prefetch/prefetch_request_fetcher.cc
diff --git a/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc b/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc
index 039faf1d36cbaeb7c435cd13448a9bd3255f80fc..92c342fc0a91f833e453b316b73f7df260f04bd3 100644
--- a/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc
+++ b/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "net/base/load_flags.h"
+#include "net/http/http_request_headers.h"
#include "net/http/http_status_code.h"
#include "net/traffic_annotation/network_traffic_annotation.h"
#include "net/url_request/url_fetcher.h"
@@ -16,11 +17,37 @@
namespace offline_pages {
namespace {
+
+const char kPrefetchServer[] =
+ "http://staging-offlinepages-pa.sandbox.googleapis.com/";
+
+// Content type needed in order to communicate with the server in binary
+// proto format.
const char kRequestContentType[] = "application/x-protobuf";
+
} // namespace
+// static
+std::unique_ptr<PrefetchRequestFetcher> PrefetchRequestFetcher::CreateForGet(
+ const std::string& url_path,
+ net::URLRequestContextGetter* request_context_getter,
+ const FinishedCallback& callback) {
+ return std::unique_ptr<PrefetchRequestFetcher>(new PrefetchRequestFetcher(
dewittj 2017/05/16 23:06:22 if you want: base::WrapUnique(...) is shorter
jianli 2017/05/16 23:52:33 Done.
+ url_path, std::string(), request_context_getter, callback));
+}
+
+// static
+std::unique_ptr<PrefetchRequestFetcher> PrefetchRequestFetcher::CreateForPost(
+ const std::string& url_path,
+ const std::string& message,
+ net::URLRequestContextGetter* request_context_getter,
+ const FinishedCallback& callback) {
+ return std::unique_ptr<PrefetchRequestFetcher>(new PrefetchRequestFetcher(
+ url_path, message, request_context_getter, callback));
+}
+
PrefetchRequestFetcher::PrefetchRequestFetcher(
- const GURL& url,
+ const std::string& url_path,
const std::string& message,
net::URLRequestContextGetter* request_context_getter,
const FinishedCallback& callback)
@@ -46,12 +73,21 @@ PrefetchRequestFetcher::PrefetchRequestFetcher(
policy_exception_justification:
"Not implemented, considered not useful."
})");
- url_fetcher_ = net::URLFetcher::Create(url, net::URLFetcher::POST, this,
- traffic_annotation);
+ url_fetcher_ = net::URLFetcher::Create(
+ GURL(kPrefetchServer + url_path),
+ message.empty() ? net::URLFetcher::GET : net::URLFetcher::POST, this,
+ traffic_annotation);
url_fetcher_->SetRequestContext(request_context_getter_.get());
url_fetcher_->SetAutomaticallyRetryOn5xx(false);
url_fetcher_->SetAutomaticallyRetryOnNetworkChanges(0);
- url_fetcher_->SetUploadData(kRequestContentType, message);
+ if (message.empty()) {
+ std::string extra_header(net::HttpRequestHeaders::kContentType);
+ extra_header += ": ";
+ extra_header += kRequestContentType;
+ url_fetcher_->AddExtraRequestHeader(extra_header);
+ } else {
+ url_fetcher_->SetUploadData(kRequestContentType, message);
+ }
url_fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
net::LOAD_DO_NOT_SAVE_COOKIES);
url_fetcher_->Start();

Powered by Google App Engine
This is Rietveld 408576698