Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2889453003: [Offline Prefetech] Send GetOperationReqest to the server (Closed)

Created:
3 years, 7 months ago by jianli
Modified:
3 years, 7 months ago
Reviewers:
dewittj
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Prefetech] Send GetOperationRequest to the server BUG=717305 TEST=new tests Review-Url: https://codereview.chromium.org/2889453003 Cr-Commit-Position: refs/heads/master@{#472956} Committed: https://chromium.googlesource.com/chromium/src/+/fe5a1735a59cd3c01e338b89d9b12bd052ac0d84

Patch Set 1 #

Total comments: 14

Patch Set 2 : Address feedback #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Address more feedback #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+835 lines, -496 lines) Patch
M components/offline_pages/core/prefetch/BUILD.gn View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M components/offline_pages/core/prefetch/generate_page_bundle_request.h View 2 chunks +2 lines, -15 lines 0 comments Download
M components/offline_pages/core/prefetch/generate_page_bundle_request.cc View 1 3 chunks +12 lines, -56 lines 0 comments Download
M components/offline_pages/core/prefetch/generate_page_bundle_request_unittest.cc View 1 2 chunks +51 lines, -262 lines 0 comments Download
A components/offline_pages/core/prefetch/get_operation_request.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A components/offline_pages/core/prefetch/get_operation_request.cc View 1 1 chunk +54 lines, -0 lines 0 comments Download
A components/offline_pages/core/prefetch/get_operation_request_unittest.cc View 1 1 chunk +83 lines, -0 lines 0 comments Download
A components/offline_pages/core/prefetch/prefetch_proto_utils.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + components/offline_pages/core/prefetch/prefetch_proto_utils.cc View 2 chunks +48 lines, -2 lines 0 comments Download
M components/offline_pages/core/prefetch/prefetch_request_fetcher.h View 1 1 chunk +21 lines, -5 lines 0 comments Download
M components/offline_pages/core/prefetch/prefetch_request_fetcher.cc View 1 2 3 3 chunks +47 lines, -4 lines 0 comments Download
M components/offline_pages/core/prefetch/prefetch_request_fetcher_unittest.cc View 1 2 chunks +30 lines, -26 lines 0 comments Download
A components/offline_pages/core/prefetch/prefetch_request_operation_response_unittest.cc View 1 1 chunk +399 lines, -0 lines 0 comments Download
M components/offline_pages/core/prefetch/prefetch_request_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/core/prefetch/prefetch_request_test_base.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M components/offline_pages/core/prefetch/prefetch_types.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
D components/offline_pages/core/prefetch/prefetch_utils.h View 1 chunk +0 lines, -27 lines 0 comments Download
D components/offline_pages/core/prefetch/prefetch_utils.cc View 1 chunk +0 lines, -94 lines 0 comments Download

Messages

Total messages: 41 (27 generated)
jianli
3 years, 7 months ago (2017-05-16 00:39:57 UTC) #4
dewittj
partial review, looks good so far. https://codereview.chromium.org/2889453003/diff/1/components/offline_pages/core/prefetch/get_operation_request.h File components/offline_pages/core/prefetch/get_operation_request.h (right): https://codereview.chromium.org/2889453003/diff/1/components/offline_pages/core/prefetch/get_operation_request.h#newcode22 components/offline_pages/core/prefetch/get_operation_request.h:22: class GetOperationRequest { ...
3 years, 7 months ago (2017-05-16 18:30:21 UTC) #7
dewittj
https://codereview.chromium.org/2889453003/diff/1/components/offline_pages/core/prefetch/prefetch_request_operation_response_unittest.cc File components/offline_pages/core/prefetch/prefetch_request_operation_response_unittest.cc (right): https://codereview.chromium.org/2889453003/diff/1/components/offline_pages/core/prefetch/prefetch_request_operation_response_unittest.cc#newcode1 components/offline_pages/core/prefetch/prefetch_request_operation_response_unittest.cc:1: // Copyright 2017 The Chromium Authors. All rights reserved. ...
3 years, 7 months ago (2017-05-16 20:35:55 UTC) #10
jianli
https://codereview.chromium.org/2889453003/diff/1/components/offline_pages/core/prefetch/get_operation_request.h File components/offline_pages/core/prefetch/get_operation_request.h (right): https://codereview.chromium.org/2889453003/diff/1/components/offline_pages/core/prefetch/get_operation_request.h#newcode22 components/offline_pages/core/prefetch/get_operation_request.h:22: class GetOperationRequest { On 2017/05/16 18:30:20, dewittj wrote: > ...
3 years, 7 months ago (2017-05-16 22:44:40 UTC) #12
dewittj
https://codereview.chromium.org/2889453003/diff/1/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc File components/offline_pages/core/prefetch/prefetch_request_fetcher.cc (right): https://codereview.chromium.org/2889453003/diff/1/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc#newcode58 components/offline_pages/core/prefetch/prefetch_request_fetcher.cc:58: GURL(kPrefetchSever + url_path), On 2017/05/16 22:44:40, jianli wrote: > ...
3 years, 7 months ago (2017-05-16 23:06:22 UTC) #16
jianli
https://codereview.chromium.org/2889453003/diff/1/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc File components/offline_pages/core/prefetch/prefetch_request_fetcher.cc (right): https://codereview.chromium.org/2889453003/diff/1/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc#newcode58 components/offline_pages/core/prefetch/prefetch_request_fetcher.cc:58: GURL(kPrefetchSever + url_path), On 2017/05/16 23:06:22, dewittj wrote: > ...
3 years, 7 months ago (2017-05-16 23:52:33 UTC) #19
dewittj
lgtm, thanks!
3 years, 7 months ago (2017-05-17 16:46:01 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889453003/60001
3 years, 7 months ago (2017-05-17 20:00:08 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889453003/60001
3 years, 7 months ago (2017-05-17 21:54:53 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458396)
3 years, 7 months ago (2017-05-18 01:23:02 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889453003/60001
3 years, 7 months ago (2017-05-18 17:52:45 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/441347) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 7 months ago (2017-05-18 18:00:19 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889453003/80001
3 years, 7 months ago (2017-05-18 18:55:59 UTC) #38
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 22:41:47 UTC) #41
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fe5a1735a59cd3c01e338b89d9b1...

Powered by Google App Engine
This is Rietveld 408576698