Chromium Code Reviews| Index: ui/aura/mus/property_converter.h |
| diff --git a/ui/aura/mus/property_converter.h b/ui/aura/mus/property_converter.h |
| index f31751a7680d391322b57145267c6359bc3c16dd..7d53b0d89cc2f8c938a3001252620013657bab78 100644 |
| --- a/ui/aura/mus/property_converter.h |
| +++ b/ui/aura/mus/property_converter.h |
| @@ -78,9 +78,8 @@ class AURA_EXPORT PropertyConverter { |
| // Register a property to support conversion between mus and aura. |
| // |validator| is a callback used to validate incoming values from |
| // transport_data; if it returns false, the value is rejected. |
| - // TODO(msw): Include type names in RegisterProperty function names. |
| template <typename T> |
| - void RegisterProperty( |
| + void RegisterPrimitiveProperty( |
| const WindowProperty<T>* property, |
| const char* transport_name, |
| const base::RepeatingCallback<bool(int64_t)>& validator) { |
| @@ -95,17 +94,16 @@ class AURA_EXPORT PropertyConverter { |
| } |
| // Register owned properties to support conversion between mus and aura. |
| - // TODO(msw): Include type names in RegisterProperty function names. |
| - void RegisterProperty(const WindowProperty<gfx::ImageSkia*>* property, |
| - const char* transport_name); |
| - void RegisterProperty(const WindowProperty<gfx::Rect*>* property, |
| - const char* transport_name); |
| - void RegisterProperty(const WindowProperty<gfx::Size*>* property, |
| - const char* transport_name); |
| - void RegisterProperty(const WindowProperty<std::string*>* property, |
| - const char* transport_name); |
| - void RegisterProperty(const WindowProperty<base::string16*>* property, |
| - const char* transport_name); |
| + void RegisterImageProperty(const WindowProperty<gfx::ImageSkia*>* property, |
|
sky
2017/05/16 12:21:34
We also have a gfx::Image class, so I'm inclined t
msw
2017/05/16 16:10:00
Done.
|
| + const char* transport_name); |
| + void RegisterRectProperty(const WindowProperty<gfx::Rect*>* property, |
| + const char* transport_name); |
| + void RegisterSizeProperty(const WindowProperty<gfx::Size*>* property, |
| + const char* transport_name); |
| + void RegisterStringProperty(const WindowProperty<std::string*>* property, |
| + const char* transport_name); |
| + void RegisterString16Property(const WindowProperty<base::string16*>* property, |
| + const char* transport_name); |
| private: |
| // Contains data needed to store and convert primitive-type properties. |