mash: Add type names to PropertyConverter::Register*Property.

ui/aura/mus/property_converter.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_AURA_MUS_PROPERTY_CONVERTER_H_
 #define UI_AURA_MUS_PROPERTY_CONVERTER_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 60 matching lines @@
   // value of false indicates the value isn't known or the property type isn't
   // primitive.
   bool GetPropertyValueFromTransportValue(
       const std::string& transport_name,
       const std::vector<uint8_t>& transport_data,
       PrimitiveType* value);
 
   // Register a property to support conversion between mus and aura.
   // |validator| is a callback used to validate incoming values from
   // transport_data; if it returns false, the value is rejected.
-  // TODO(msw): Include type names in RegisterProperty function names.
   template <typename T>
-  void RegisterProperty(
+  void RegisterPrimitiveProperty(
       const WindowProperty<T>* property,
       const char* transport_name,
       const base::RepeatingCallback<bool(int64_t)>& validator) {
     PrimitiveProperty primitive_property;
     primitive_property.property_name = property->name;
     primitive_property.transport_name = transport_name;
     primitive_property.default_value =
         ui::ClassPropertyCaster<T>::ToInt64(property->default_value);
     primitive_property.validator = validator;
     primitive_properties_[property] = primitive_property;
     transport_names_.insert(transport_name);
   }
 
   // Register owned properties to support conversion between mus and aura.
-  // TODO(msw): Include type names in RegisterProperty function names.
-  void RegisterProperty(const WindowProperty<gfx::ImageSkia*>* property,
-                        const char* transport_name);
-  void RegisterProperty(const WindowProperty<gfx::Rect*>* property,
-                        const char* transport_name);
-  void RegisterProperty(const WindowProperty<gfx::Size*>* property,
-                        const char* transport_name);
-  void RegisterProperty(const WindowProperty<std::string*>* property,
-                        const char* transport_name);
-  void RegisterProperty(const WindowProperty<base::string16*>* property,
-                        const char* transport_name);
+  void RegisterImageProperty(const WindowProperty<gfx::ImageSkia*>* property,

[sky, 2017/05/16 12:21:34]

We also have a gfx::Image class, so I'm inclined to be explicit here and rename
RegisterImageSkiaProperty.

[msw, 2017/05/16 16:10:00]

Done.

+                             const char* transport_name);
+  void RegisterRectProperty(const WindowProperty<gfx::Rect*>* property,
+                            const char* transport_name);
+  void RegisterSizeProperty(const WindowProperty<gfx::Size*>* property,
+                            const char* transport_name);
+  void RegisterStringProperty(const WindowProperty<std::string*>* property,
+                              const char* transport_name);
+  void RegisterString16Property(const WindowProperty<base::string16*>* property,
+                                const char* transport_name);
 
  private:
   // Contains data needed to store and convert primitive-type properties.
   struct AURA_EXPORT PrimitiveProperty {
     PrimitiveProperty();
     PrimitiveProperty(const PrimitiveProperty& property);
     ~PrimitiveProperty();
 
     // The aura::WindowProperty::name used for storage.
     const char* property_name = nullptr;
@@ skipping 21 matching lines @@
 
   // Set of transport names supplied to RegisterProperty().
   std::set<std::string> transport_names_;
 
   DISALLOW_COPY_AND_ASSIGN(PropertyConverter);
 };
 
 }  // namespace aura
 
 #endif  // UI_AURA_MUS_PROPERTY_CONVERTER_H_