Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc

Issue 2889443002: mash: Add type names to PropertyConverter::Register*Property. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
diff --git a/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc b/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
index 0452f4566d5c5dc346e181617b835f51d4c1c547..5a405320b0eb9732078b38e1a1095e3dd96fbeb5 100644
--- a/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
+++ b/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
@@ -49,19 +49,19 @@ void ChromeBrowserMainExtraPartsAsh::ServiceManagerConnectionStarted(
aura::WindowTreeClientDelegate* delegate = mus_client;
aura::PropertyConverter* converter = delegate->GetPropertyConverter();
- converter->RegisterProperty(
+ converter->RegisterPrimitiveProperty(
ash::kPanelAttachedKey,
ui::mojom::WindowManager::kPanelAttached_Property,
aura::PropertyConverter::CreateAcceptAnyValueCallback());
- converter->RegisterProperty(ash::kShelfIDKey,
- ui::mojom::WindowManager::kShelfID_Property);
- converter->RegisterProperty(
+ converter->RegisterStringProperty(
+ ash::kShelfIDKey, ui::mojom::WindowManager::kShelfID_Property);
+ converter->RegisterPrimitiveProperty(
ash::kShelfItemTypeKey,
ui::mojom::WindowManager::kShelfItemType_Property,
base::Bind(&ash::IsValidShelfItemType));
- converter->RegisterProperty(ash::kWindowPinTypeKey,
- ash::mojom::kWindowPinType_Property,
- base::Bind(&ash::IsValidWindowPinType));
+ converter->RegisterPrimitiveProperty(
+ ash::kWindowPinTypeKey, ash::mojom::kWindowPinType_Property,
+ base::Bind(&ash::IsValidWindowPinType));
mus_client->SetMusPropertyMirror(
base::MakeUnique<ash::MusPropertyMirrorAsh>());

Powered by Google App Engine
This is Rietveld 408576698