Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: ash/mus/window_manager.cc

Issue 2889443002: mash: Add type names to PropertyConverter::Register*Property. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/mus/window_manager.cc
diff --git a/ash/mus/window_manager.cc b/ash/mus/window_manager.cc
index 98e41b45ab8e8e879920922e0bc3c53e56d7386e..c439565a7749c8ab61a35a5bb6c5f94e4c0c7e7d 100644
--- a/ash/mus/window_manager.cc
+++ b/ash/mus/window_manager.cc
@@ -82,25 +82,25 @@ WindowManager::WindowManager(service_manager::Connector* connector,
show_primary_host_on_connect_(show_primary_host_on_connect),
wm_state_(base::MakeUnique<::wm::WMState>()),
property_converter_(base::MakeUnique<aura::PropertyConverter>()) {
- property_converter_->RegisterProperty(
+ property_converter_->RegisterPrimitiveProperty(
kPanelAttachedKey, ui::mojom::WindowManager::kPanelAttached_Property,
aura::PropertyConverter::CreateAcceptAnyValueCallback());
- property_converter_->RegisterProperty(
+ property_converter_->RegisterPrimitiveProperty(
kRenderTitleAreaProperty,
ui::mojom::WindowManager::kRenderParentTitleArea_Property,
aura::PropertyConverter::CreateAcceptAnyValueCallback());
- property_converter_->RegisterProperty(
+ property_converter_->RegisterStringProperty(
kShelfIDKey, ui::mojom::WindowManager::kShelfID_Property);
- property_converter_->RegisterProperty(
+ property_converter_->RegisterPrimitiveProperty(
kShelfItemTypeKey, ui::mojom::WindowManager::kShelfItemType_Property,
base::Bind(&IsValidShelfItemType));
- property_converter_->RegisterProperty(
+ property_converter_->RegisterPrimitiveProperty(
::wm::kShadowElevationKey,
ui::mojom::WindowManager::kShadowElevation_Property,
base::Bind(&::wm::IsValidShadowElevation));
- property_converter_->RegisterProperty(kWindowPinTypeKey,
- ash::mojom::kWindowPinType_Property,
- base::Bind(&ash::IsValidWindowPinType));
+ property_converter_->RegisterPrimitiveProperty(
+ kWindowPinTypeKey, ash::mojom::kWindowPinType_Property,
+ base::Bind(&ash::IsValidWindowPinType));
}
WindowManager::~WindowManager() {
« no previous file with comments | « no previous file | chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc » ('j') | ui/aura/mus/property_converter.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698