Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2889433002:
Workaround transform node NPE in draw_property_utils::UpdateElasticOverscroll (Closed)
DescriptionWorkaround transform node NPE in draw_property_utils::UpdateElasticOverscroll
We have reports of crashes in draw_property_utils::UpdateElasticOverscroll
due to the transform node being null. We do not think this should be
possible. This patch works around this issue by adding a DCHECK and safely
returning from the function.
This bug may be related to https://crbug.com/712298 which is a similar null
transform issue.
BUG=721772
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2889433002
Cr-Commit-Position: refs/heads/master@{#471997}
Committed: https://chromium.googlesource.com/chromium/src/+/9bfc581b8128132f61d342bd383d356feb0c8f0b
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
pdr@chromium.org changed reviewers: + enne@chromium.org, weiliangc@chromium.org
pdr@chromium.org changed reviewers: + chrishtr@chromium.org
lgtm
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494901664019850, "parent_rev":
"dd78b5d7e2b3613a2e8b205aa7d1143bfc9ce2de", "commit_rev":
"9bfc581b8128132f61d342bd383d356feb0c8f0b"}
Message was sent while issue was closed.
Description was changed from ========== Workaround transform node NPE in draw_property_utils::UpdateElasticOverscroll We have reports of crashes in draw_property_utils::UpdateElasticOverscroll due to the transform node being null. We do not think this should be possible. This patch works around this issue by adding a DCHECK and safely returning from the function. This bug may be related to https://crbug.com/712298 which is a similar null transform issue. BUG=721772 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Workaround transform node NPE in draw_property_utils::UpdateElasticOverscroll We have reports of crashes in draw_property_utils::UpdateElasticOverscroll due to the transform node being null. We do not think this should be possible. This patch works around this issue by adding a DCHECK and safely returning from the function. This bug may be related to https://crbug.com/712298 which is a similar null transform issue. BUG=721772 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2889433002 Cr-Commit-Position: refs/heads/master@{#471997} Committed: https://chromium.googlesource.com/chromium/src/+/9bfc581b8128132f61d342bd383d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9bfc581b8128132f61d342bd383d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
