Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2889413002: chromeos: nukes window_state_aura (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, awdf+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dcheng, extensions-reviews_chromium.org, kalyank, mlamouri+watch-notifications_chromium.org, oshima+watch_chromium.org, Peter Beverloo, posciak+watch_chromium.org, sadrul, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: nukes window_state_aura And moves the lookup functions in window_state. I would prefer these functions be static functions on WindowState, but that's for another day. BUG=722553 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2889413002 Cr-Commit-Position: refs/heads/master@{#473369} Committed: https://chromium.googlesource.com/chromium/src/+/a781fb649239a915431b9ab98a8e6e0f4155f2fa

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge, remove include from windows and shuffle functions for declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -171 lines) Patch
M ash/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_commands_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_delegate_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_interactive_uitest_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/display_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/toplevel_window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/ash_focus_rules.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/ash_focus_rules_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/fullscreen_window_finder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/lock_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/lock_layout_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/mru_window_tracker_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_grid.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/panels/panel_window_event_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/resize_handle_window_targeter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/resize_shadow_and_cursor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/video_detector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/video_detector_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_animations_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_cycle_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_mirror_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_positioner_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_state.h View 1 2 2 chunks +13 lines, -3 lines 0 comments Download
M ash/wm/window_state.cc View 2 chunks +22 lines, -0 lines 0 comments Download
D ash/wm/window_state_aura.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ash/wm/window_state_aura.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M ash/wm/window_state_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm_window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/fullscreen_notification_blocker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/accelerator_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/exo/shell_surface.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/exo/shell_surface_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
sky
3 years, 7 months ago (2017-05-19 15:24:08 UTC) #1
sky
msw->erg to as msw as OOO today reveman for exo
3 years, 7 months ago (2017-05-19 15:24:50 UTC) #5
reveman
lgtm
3 years, 7 months ago (2017-05-19 15:36:28 UTC) #7
Elliot Glaysher
lgtm
3 years, 7 months ago (2017-05-19 17:09:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889413002/20001
3 years, 7 months ago (2017-05-19 17:14:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/415785)
3 years, 7 months ago (2017-05-19 18:34:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889413002/40001
3 years, 7 months ago (2017-05-19 19:36:42 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 22:36:14 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a781fb649239a915431b9ab98a8e...

Powered by Google App Engine
This is Rietveld 408576698