Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2889383002: Revert of Make Hands-Off Zero-Touch Enrollment compatibile with tests (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make Hands-Off Zero-Touch Enrollment compatibile with tests (patchset #10 id:180001 of https://codereview.chromium.org/2870203003/ ) Reason for revert: UpdateScreenUnitTest is failing on ASan LSan: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/21254 Original issue's description: > Make Hands-Off Zero-Touch Enrollment compatibile with tests > > Specifically, the automatic nature of Hands-Off Enrollment leads to > the DUT performing an update check after reboot which interferes > with autoupdate_EndToEndTest. This CL fixes that issue. > It does so by instructing the UpdateScreen to skip checking for updates > if both of the following conditions hold: > 1. The previous update check initiated by the UpdateScreen did not result > in an update. > 2. This previous update check occurred during the last hour. > > BUG=chromium:710716 > TEST=unit test > > Review-Url: https://codereview.chromium.org/2870203003 > Cr-Commit-Position: refs/heads/master@{#473065} > Committed: https://chromium.googlesource.com/chromium/src/+/0e9353d37e60a871304084a1b34222062c4803e9 TBR=xiyuan@chromium.org,alemate@chromium.org,kumarniranjan@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:710716 Review-Url: https://codereview.chromium.org/2889383002 Cr-Commit-Position: refs/heads/master@{#473137} Committed: https://chromium.googlesource.com/chromium/src/+/006210c0d82e054c7474fdb76501c5b59279fecb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -488 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc View 2 chunks +25 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/screen_exit_code.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.h View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 3 chunks +5 lines, -44 lines 0 comments Download
D chrome/browser/chromeos/login/screens/update_screen_unittest.cc View 1 chunk +0 lines, -302 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chromeos/network/portal_detector/mock_network_portal_detector.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chromeos/network/portal_detector/mock_network_portal_detector.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chromeos/network/portal_detector/network_portal_detector.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Marc Treib
Created Revert of Make Hands-Off Zero-Touch Enrollment compatibile with tests
3 years, 7 months ago (2017-05-19 09:27:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889383002/1
3 years, 7 months ago (2017-05-19 09:27:40 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 09:28:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/006210c0d82e054c7474fdb76501...

Powered by Google App Engine
This is Rietveld 408576698