Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2889333002: [MD settings] move polymer.html imports to top of file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by dschuyler
Modified:
3 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dcheng, extensions-reviews_chromium.org, gcasto+watchlist_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] move polymer.html imports to top of file This Cl moves the imports of polymer.html to the top of the file so that polymer.html is imported before other files. This is an exception to the normal alphabetical order of imports. A blank line is added under this first import to visually separate it from the rest of the imports, since it's special. This ensures that custom elements are always configured according to polymer_config.js, which has to be loaded before any Polymer code. This is a mechanical (scripted) change. (code health) BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2889333002 Cr-Commit-Position: refs/heads/master@{#473220} Committed: https://chromium.googlesource.com/chromium/src/+/9fe4c439346a542a207dc9122fe68b8a40f68dcd

Patch Set 1 : rerun #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -102 lines) Patch
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/manage_a11y_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/about_page/channel_switcher_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/about_page/detailed_build_info.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/about_page/update_warning_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/android_apps_page/android_apps_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_list.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/controlled_button.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/controlled_radio_button.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/extension_controlled_indicator.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/important_site_checkbox.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/controls/pref_control_behavior.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_boolean_control_behavior.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_checkbox.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_dropdown_menu.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_radio_group.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_slider.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_toggle_button.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/default_browser_page/default_browser_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/device_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/display.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/display_layout.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/display_overscan_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/drive_cache_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/keyboard.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/pointers.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/power.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/storage.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/stylus.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/icons.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_subpage.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_apnlist.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_ip_config.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_nameservers.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_property_list.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy_exclusions.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy_input.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_siminfo.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/tether_connection_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/add_languages_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/languages.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/manage_input_methods_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/on_startup_page/on_startup_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_url_entry.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/camera.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/fingerprint_list.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/import_data_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/lock_screen.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/lock_state_behavior.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/manage_profile.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/password_prompt_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/setup_pin_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/user_list.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/users_add_user_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/users_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/prefs/prefs.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/printing_page/cloud_printers.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_printer_details_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_printers.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_printers_list.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/printing_page/printing_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/reset_page/powerwash_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_profile_banner.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_profile_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_entry.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engines_list.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engines_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_page/main_page_behavior.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_animated_pages.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_section.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_subpage.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_subpage_search.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_page_css.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/add_site_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/all_sites.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/category_default_setting.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/category_setting_exceptions.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/edit_exception_dialog.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/media_picker.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/pdf_documents.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/protocol_handlers.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data_details_subpage.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details_permission.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/usb_devices.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/website_usage_private_api.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/zoom_levels.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings_page/site_settings_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/system_page/system_page.html View 1 chunk +2 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 18 (14 generated)
dschuyler
A mechanical (scripted) change.
3 months ago (2017-05-19 01:32:40 UTC) #9
dpapad
LGTM with one request. The CL description describes what is being done, but does not ...
3 months ago (2017-05-19 01:44:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889333002/20001
3 months ago (2017-05-19 17:00:37 UTC) #15
commit-bot: I haz the power
3 months ago (2017-05-19 17:10:41 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9fe4c439346a542a207dc9122fe6...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b