Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2889303003: Revert of Mitigate spoofing attempt using Latin letters. (Closed)

Created:
3 years, 7 months ago by tsergeant
Modified:
3 years, 7 months ago
CC:
chromium-reviews, emilyschechter
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mitigate spoofing attempt using Latin letters. (patchset #47 id:850001 of https://codereview.chromium.org/2784933002/ ) Reason for revert: This CL is causing compile to fail on Win x64: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/11432 FAILED: obj/components/url_formatter/top_domains/make_top_domain_gperf/make_top_domain_gperf.obj make_top_domain_gperf.cc(46): error C2220: warning treated as error - no 'object' file generated make_top_domain_gperf.cc(46): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data Original issue's description: > Add checks against spoofing attempt at top domains > > Remove diacritic marks from a hostname and calculate the confusability > skeleton of the accent-free name. Look it up in the pre-calculated list of > the skeletons of top 10k domains. > > Removing diacritic marks from a hostname is equivalent to comparing names with > the primary collation strength in the root locale. To make them equivalent, > three mappings are added (ł > l; ø > o; đ > d) on top of the diacritic-removal. > Also add two more mappings ([кĸκ] > k, п > n) to supplement the Unicode's > confusables list. > > Binary file size increase: ~ 59kB for the DAFSA representation of top > domain name skeletons. > > The IDN display policy check takes ~ 2µs longer on the average (3.3 µs => 5.5µs) > on my machine per the test run over ~1 million IDNs in com TLD). > > It adds about 1500 domains to the list of domains to display in Punycode out > of ~ 1 million IDNs in com TLD. (3018 => 4571) > > In addition, disallow combining diarctic marks unless they're preceded by > Latin-Greek-Cyrillic. > > BUG=703750, 714628, 719199, 722639 > TEST=components_unittests --gtest_filter=*IDNToUni* > > Review-Url: https://codereview.chromium.org/2784933002 > Cr-Commit-Position: refs/heads/master@{#473109} > Committed: https://chromium.googlesource.com/chromium/src/+/a8add0308ba6067eb3de5a8fe82f9c2f2460ad91 TBR=rsleevi@chromium.org,pkasting@chromium.org,nick@chromium.org,brettw@chromium.org,emilyschechter@chromium.org,jshin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703750, 714628, 719199, 722639 Review-Url: https://codereview.chromium.org/2889303003 Cr-Commit-Position: refs/heads/master@{#473118} Committed: https://chromium.googlesource.com/chromium/src/+/4eec0f46bf71277f9de364ea8f4fb2f41d894b16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18752 lines) Patch
M components/url_formatter/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/url_formatter/idn_spoof_checker.h View 3 chunks +0 lines, -15 lines 0 comments Download
M components/url_formatter/idn_spoof_checker.cc View 9 chunks +8 lines, -104 lines 0 comments Download
D components/url_formatter/top_domains/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D components/url_formatter/top_domains/README View 1 chunk +0 lines, -16 lines 0 comments Download
D components/url_formatter/top_domains/alexa_domains.list View 1 chunk +0 lines, -9176 lines 0 comments Download
D components/url_formatter/top_domains/alexa_skeletons.gperf View 1 chunk +0 lines, -9186 lines 0 comments Download
D components/url_formatter/top_domains/make_alexa_top_list.py View 1 chunk +0 lines, -55 lines 0 comments Download
D components/url_formatter/top_domains/make_top_domain_gperf.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M components/url_formatter/url_formatter.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M components/url_formatter/url_formatter_unittest.cc View 4 chunks +5 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tsergeant
Created Revert of Mitigate spoofing attempt using Latin letters.
3 years, 7 months ago (2017-05-19 07:23:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889303003/1
3 years, 7 months ago (2017-05-19 07:24:09 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 07:25:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4eec0f46bf71277f9de364ea8f4f...

Powered by Google App Engine
This is Rietveld 408576698