Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: net/ssl/ssl_config_unittest.cc

Issue 2889273003: Fix some non-const ref function argument types. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_stream_factory_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_config_unittest.cc
diff --git a/net/ssl/ssl_config_unittest.cc b/net/ssl/ssl_config_unittest.cc
index cadce31ce6421a4168f9684413ab49e904095d00..437edd5bd0244d0432b3064064e3c66034f79a55 100644
--- a/net/ssl/ssl_config_unittest.cc
+++ b/net/ssl/ssl_config_unittest.cc
@@ -11,17 +11,17 @@ namespace net {
namespace {
-void CheckCertVerifyFlags(SSLConfig& ssl_config,
+void CheckCertVerifyFlags(SSLConfig* ssl_config,
bool rev_checking_enabled,
bool verify_ev_cert,
bool cert_io_enabled,
bool rev_checking_required_local_anchors) {
- ssl_config.rev_checking_enabled = rev_checking_enabled;
- ssl_config.verify_ev_cert = verify_ev_cert;
- ssl_config.cert_io_enabled = cert_io_enabled;
- ssl_config.rev_checking_required_local_anchors =
+ ssl_config->rev_checking_enabled = rev_checking_enabled;
+ ssl_config->verify_ev_cert = verify_ev_cert;
+ ssl_config->cert_io_enabled = cert_io_enabled;
+ ssl_config->rev_checking_required_local_anchors =
rev_checking_required_local_anchors;
- int flags = ssl_config.GetCertVerifyFlags();
+ int flags = ssl_config->GetCertVerifyFlags();
if (rev_checking_enabled)
EXPECT_TRUE(flags & CertVerifier::VERIFY_REV_CHECKING_ENABLED);
else
@@ -47,37 +47,37 @@ void CheckCertVerifyFlags(SSLConfig& ssl_config,
TEST(SSLConfigTest, GetCertVerifyFlags) {
SSLConfig ssl_config;
- CheckCertVerifyFlags(ssl_config,
+ CheckCertVerifyFlags(&ssl_config,
/*rev_checking_enabled=*/true,
/*verify_ev_cert=*/true,
/*cert_io_enabled=*/true,
/*rev_checking_required_local_anchors=*/true);
- CheckCertVerifyFlags(ssl_config,
+ CheckCertVerifyFlags(&ssl_config,
/*rev_checking_enabled=*/false,
/*verify_ev_cert=*/false,
/*cert_io_enabled=*/false,
/*rev_checking_required_local_anchors=*/false);
- CheckCertVerifyFlags(ssl_config,
+ CheckCertVerifyFlags(&ssl_config,
/*rev_checking_enabled=*/true,
/*verify_ev_cert=*/false,
/*cert_io_enabled=*/false,
/*rev_checking_required_local_anchors=*/false);
- CheckCertVerifyFlags(ssl_config,
+ CheckCertVerifyFlags(&ssl_config,
/*rev_checking_enabled=*/false,
/*verify_ev_cert=*/true,
/*cert_io_enabled=*/false,
/*rev_checking_required_local_anchors=*/false);
- CheckCertVerifyFlags(ssl_config,
+ CheckCertVerifyFlags(&ssl_config,
/*rev_checking_enabled=*/false,
/*verify_ev_cert=*/false,
/*cert_io_enabled=*/true,
/*rev_checking_required_local_anchors=*/false);
- CheckCertVerifyFlags(ssl_config,
+ CheckCertVerifyFlags(&ssl_config,
/*rev_checking_enabled=*/false,
/*verify_ev_cert=*/false,
/*cert_io_enabled=*/false,
« no previous file with comments | « net/quic/chromium/quic_stream_factory_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698