Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Side by Side Diff: net/ssl/ssl_config_unittest.cc

Issue 2889273003: Fix some non-const ref function argument types. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/chromium/quic_stream_factory_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/ssl/ssl_config.h" 5 #include "net/ssl/ssl_config.h"
6 6
7 #include "net/cert/cert_verifier.h" 7 #include "net/cert/cert_verifier.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace net { 10 namespace net {
11 11
12 namespace { 12 namespace {
13 13
14 void CheckCertVerifyFlags(SSLConfig& ssl_config, 14 void CheckCertVerifyFlags(SSLConfig* ssl_config,
15 bool rev_checking_enabled, 15 bool rev_checking_enabled,
16 bool verify_ev_cert, 16 bool verify_ev_cert,
17 bool cert_io_enabled, 17 bool cert_io_enabled,
18 bool rev_checking_required_local_anchors) { 18 bool rev_checking_required_local_anchors) {
19 ssl_config.rev_checking_enabled = rev_checking_enabled; 19 ssl_config->rev_checking_enabled = rev_checking_enabled;
20 ssl_config.verify_ev_cert = verify_ev_cert; 20 ssl_config->verify_ev_cert = verify_ev_cert;
21 ssl_config.cert_io_enabled = cert_io_enabled; 21 ssl_config->cert_io_enabled = cert_io_enabled;
22 ssl_config.rev_checking_required_local_anchors = 22 ssl_config->rev_checking_required_local_anchors =
23 rev_checking_required_local_anchors; 23 rev_checking_required_local_anchors;
24 int flags = ssl_config.GetCertVerifyFlags(); 24 int flags = ssl_config->GetCertVerifyFlags();
25 if (rev_checking_enabled) 25 if (rev_checking_enabled)
26 EXPECT_TRUE(flags & CertVerifier::VERIFY_REV_CHECKING_ENABLED); 26 EXPECT_TRUE(flags & CertVerifier::VERIFY_REV_CHECKING_ENABLED);
27 else 27 else
28 EXPECT_FALSE(flags & CertVerifier::VERIFY_REV_CHECKING_ENABLED); 28 EXPECT_FALSE(flags & CertVerifier::VERIFY_REV_CHECKING_ENABLED);
29 if (verify_ev_cert) 29 if (verify_ev_cert)
30 EXPECT_TRUE(flags & CertVerifier::VERIFY_EV_CERT); 30 EXPECT_TRUE(flags & CertVerifier::VERIFY_EV_CERT);
31 else 31 else
32 EXPECT_FALSE(flags & CertVerifier::VERIFY_EV_CERT); 32 EXPECT_FALSE(flags & CertVerifier::VERIFY_EV_CERT);
33 if (cert_io_enabled) 33 if (cert_io_enabled)
34 EXPECT_TRUE(flags & CertVerifier::VERIFY_CERT_IO_ENABLED); 34 EXPECT_TRUE(flags & CertVerifier::VERIFY_CERT_IO_ENABLED);
35 else 35 else
36 EXPECT_FALSE(flags & CertVerifier::VERIFY_CERT_IO_ENABLED); 36 EXPECT_FALSE(flags & CertVerifier::VERIFY_CERT_IO_ENABLED);
37 if (rev_checking_required_local_anchors) { 37 if (rev_checking_required_local_anchors) {
38 EXPECT_TRUE(flags & 38 EXPECT_TRUE(flags &
39 CertVerifier::VERIFY_REV_CHECKING_REQUIRED_LOCAL_ANCHORS); 39 CertVerifier::VERIFY_REV_CHECKING_REQUIRED_LOCAL_ANCHORS);
40 } else { 40 } else {
41 EXPECT_FALSE(flags & 41 EXPECT_FALSE(flags &
42 CertVerifier::VERIFY_REV_CHECKING_REQUIRED_LOCAL_ANCHORS); 42 CertVerifier::VERIFY_REV_CHECKING_REQUIRED_LOCAL_ANCHORS);
43 } 43 }
44 } 44 }
45 45
46 } // namespace 46 } // namespace
47 47
48 TEST(SSLConfigTest, GetCertVerifyFlags) { 48 TEST(SSLConfigTest, GetCertVerifyFlags) {
49 SSLConfig ssl_config; 49 SSLConfig ssl_config;
50 CheckCertVerifyFlags(ssl_config, 50 CheckCertVerifyFlags(&ssl_config,
51 /*rev_checking_enabled=*/true, 51 /*rev_checking_enabled=*/true,
52 /*verify_ev_cert=*/true, 52 /*verify_ev_cert=*/true,
53 /*cert_io_enabled=*/true, 53 /*cert_io_enabled=*/true,
54 /*rev_checking_required_local_anchors=*/true); 54 /*rev_checking_required_local_anchors=*/true);
55 55
56 CheckCertVerifyFlags(ssl_config, 56 CheckCertVerifyFlags(&ssl_config,
57 /*rev_checking_enabled=*/false, 57 /*rev_checking_enabled=*/false,
58 /*verify_ev_cert=*/false, 58 /*verify_ev_cert=*/false,
59 /*cert_io_enabled=*/false, 59 /*cert_io_enabled=*/false,
60 /*rev_checking_required_local_anchors=*/false); 60 /*rev_checking_required_local_anchors=*/false);
61 61
62 CheckCertVerifyFlags(ssl_config, 62 CheckCertVerifyFlags(&ssl_config,
63 /*rev_checking_enabled=*/true, 63 /*rev_checking_enabled=*/true,
64 /*verify_ev_cert=*/false, 64 /*verify_ev_cert=*/false,
65 /*cert_io_enabled=*/false, 65 /*cert_io_enabled=*/false,
66 /*rev_checking_required_local_anchors=*/false); 66 /*rev_checking_required_local_anchors=*/false);
67 67
68 CheckCertVerifyFlags(ssl_config, 68 CheckCertVerifyFlags(&ssl_config,
69 /*rev_checking_enabled=*/false, 69 /*rev_checking_enabled=*/false,
70 /*verify_ev_cert=*/true, 70 /*verify_ev_cert=*/true,
71 /*cert_io_enabled=*/false, 71 /*cert_io_enabled=*/false,
72 /*rev_checking_required_local_anchors=*/false); 72 /*rev_checking_required_local_anchors=*/false);
73 73
74 CheckCertVerifyFlags(ssl_config, 74 CheckCertVerifyFlags(&ssl_config,
75 /*rev_checking_enabled=*/false, 75 /*rev_checking_enabled=*/false,
76 /*verify_ev_cert=*/false, 76 /*verify_ev_cert=*/false,
77 /*cert_io_enabled=*/true, 77 /*cert_io_enabled=*/true,
78 /*rev_checking_required_local_anchors=*/false); 78 /*rev_checking_required_local_anchors=*/false);
79 79
80 CheckCertVerifyFlags(ssl_config, 80 CheckCertVerifyFlags(&ssl_config,
81 /*rev_checking_enabled=*/false, 81 /*rev_checking_enabled=*/false,
82 /*verify_ev_cert=*/false, 82 /*verify_ev_cert=*/false,
83 /*cert_io_enabled=*/false, 83 /*cert_io_enabled=*/false,
84 /*rev_checking_required_local_anchors=*/true); 84 /*rev_checking_required_local_anchors=*/true);
85 } 85 }
86 86
87 } // namespace net 87 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/chromium/quic_stream_factory_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698