Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc

Issue 2889273002: Revert of [GRC] Process Coordination Unit support for Global Resource Controller (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/resource_coordinator/coordination_unit/coordination_unit_prov ider_impl.h" 5 #include "services/resource_coordinator/coordination_unit/coordination_unit_prov ider_impl.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "mojo/public/cpp/bindings/strong_binding.h" 11 #include "mojo/public/cpp/bindings/strong_binding.h"
12 #include "services/resource_coordinator/coordination_unit/coordination_unit_fact ory.h"
13 #include "services/resource_coordinator/coordination_unit/coordination_unit_impl .h" 12 #include "services/resource_coordinator/coordination_unit/coordination_unit_impl .h"
14 #include "services/service_manager/public/cpp/service_context_ref.h" 13 #include "services/service_manager/public/cpp/service_context_ref.h"
15 14
16 namespace resource_coordinator { 15 namespace resource_coordinator {
17 16
18 CoordinationUnitProviderImpl::CoordinationUnitProviderImpl( 17 CoordinationUnitProviderImpl::CoordinationUnitProviderImpl(
19 service_manager::ServiceContextRefFactory* service_ref_factory) 18 service_manager::ServiceContextRefFactory* service_ref_factory)
20 : service_ref_factory_(service_ref_factory) { 19 : service_ref_factory_(service_ref_factory) {
21 DCHECK(service_ref_factory); 20 DCHECK(service_ref_factory);
22 service_ref_ = service_ref_factory->CreateRef(); 21 service_ref_ = service_ref_factory->CreateRef();
23 } 22 }
24 23
25 CoordinationUnitProviderImpl::~CoordinationUnitProviderImpl() = default; 24 CoordinationUnitProviderImpl::~CoordinationUnitProviderImpl() = default;
26 25
27 void CoordinationUnitProviderImpl::CreateCoordinationUnit( 26 void CoordinationUnitProviderImpl::CreateCoordinationUnit(
28 mojom::CoordinationUnitRequest request, 27 mojom::CoordinationUnitRequest request,
29 const CoordinationUnitID& id) { 28 const CoordinationUnitID& id) {
30 std::unique_ptr<CoordinationUnitImpl> coordination_unit = 29 // TODO(oysteine): A strong binding here means the first binding set up
31 coordination_unit_factory::CreateCoordinationUnit( 30 // to a CoordinationUnit via CoordinationUnitProvider, i.e. the authoritative
32 id, service_ref_factory_->CreateRef()); 31 // one in terms of setting the context, has to outlive all of the other
32 // connections (as the rest are just duplicated and held within
33 // CoordinationUnit). Make sure this assumption is correct, or refactor into
34 // some kind of refcounted thing.
33 35
34 mojo::MakeStrongBinding(std::move(coordination_unit), std::move(request)); 36 // Once there's a need for custom code for various types of CUs (tabs,
37 // processes, etc) then this could become a factory function and instantiate
38 // different subclasses of CoordinationUnitImpl based on the id.type.
39 mojo::MakeStrongBinding(base::MakeUnique<CoordinationUnitImpl>(
40 id, service_ref_factory_->CreateRef()),
41 std::move(request));
35 }; 42 };
36 43
37 // static 44 // static
38 void CoordinationUnitProviderImpl::Create( 45 void CoordinationUnitProviderImpl::Create(
39 service_manager::ServiceContextRefFactory* service_ref_factory, 46 service_manager::ServiceContextRefFactory* service_ref_factory,
40 const service_manager::BindSourceInfo& source_info, 47 const service_manager::BindSourceInfo& source_info,
41 resource_coordinator::mojom::CoordinationUnitProviderRequest request) { 48 resource_coordinator::mojom::CoordinationUnitProviderRequest request) {
42 mojo::MakeStrongBinding( 49 mojo::MakeStrongBinding(
43 base::MakeUnique<CoordinationUnitProviderImpl>(service_ref_factory), 50 base::MakeUnique<CoordinationUnitProviderImpl>(service_ref_factory),
44 std::move(request)); 51 std::move(request));
45 } 52 }
46 53
47 } // namespace resource_coordinator 54 } // namespace resource_coordinator
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698