Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2889273002: Revert of [GRC] Process Coordination Unit support for Global Resource Controller (Closed)

Created:
3 years, 7 months ago by matthalp
Modified:
3 years, 7 months ago
CC:
chrome-grc-reviews_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [GRC] Process Coordination Unit support for Global Resource Controller (patchset #7 id:120001 of https://codereview.chromium.org/2892443002/ ) Reason for revert: CQed before having final LGTM Original issue's description: > [GRC] Process Coordination Unit support for Global Resource Controller > > Quick design tl;dr: > > * ProcessCoordinationUnitImpl > Specific implementation of CoordinationUnitImpl for tracking > processes within GRC of which it is derived from > > * CoordinationUnitFactory > Currently supports making ProcessCoordinationUnitImpl for > CoordinationUnitType:kProcess and then a vanilla > CoordinationUnitImpl for any ohter CoordinationUnitType > > * CoordinationUnitImplBaseTest > A base class for unit testing CoordinationUnitImpl and > its derived classes > > R=oysteine@chromium.org, rockot@chromium.org > BUG=724306 TBR=rockot@chromium.org,oysteine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=724306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -334 lines) Patch
M services/resource_coordinator/BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download
M services/resource_coordinator/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D services/resource_coordinator/coordination_unit/coordination_unit_factory.h View 1 chunk +0 lines, -30 lines 0 comments Download
D services/resource_coordinator/coordination_unit/coordination_unit_factory.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M services/resource_coordinator/coordination_unit/coordination_unit_impl.h View 3 chunks +1 line, -7 lines 0 comments Download
M services/resource_coordinator/coordination_unit/coordination_unit_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest.cc View 2 chunks +24 lines, -3 lines 0 comments Download
D services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest_util.h View 1 chunk +0 lines, -37 lines 0 comments Download
D services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest_util.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc View 2 chunks +12 lines, -5 lines 0 comments Download
D services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M services/resource_coordinator/public/cpp/coordination_unit_id.h View 2 chunks +2 lines, -9 lines 0 comments Download
M services/resource_coordinator/public/cpp/coordination_unit_id.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M services/resource_coordinator/public/cpp/resource_coordinator_interface.h View 2 chunks +2 lines, -5 lines 0 comments Download
M services/resource_coordinator/public/cpp/resource_coordinator_interface.cc View 1 chunk +9 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
matthalp
Created Revert of [GRC] Process Coordination Unit support for Global Resource Controller
3 years, 7 months ago (2017-05-18 23:42:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889273002/1
3 years, 7 months ago (2017-05-18 23:43:54 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 23:43:57 UTC) #5
No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698