Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2889263002: Remove Interface ID Template Parameter from ScopedComPtr (Closed)

Created:
3 years, 7 months ago by robliao
Modified:
3 years, 7 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, wfh+watch_chromium.org, feature-media-reviews_chromium.org, tfarina, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Interface ID Template Parameter from ScopedComPtr ScopedComPtr no longer uses this template parameter. BUG=638327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=dalecurtis@chromium.org, nicholss@chromium.org, thakis@chromium.org, Mechanical refactor. Review-Url: https://codereview.chromium.org/2889263002 Cr-Commit-Position: refs/heads/master@{#473222} Committed: https://chromium.googlesource.com/chromium/src/+/6d2438074669d3251deee6d17a9e6692ffcff297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -27 lines) Patch
M base/win/scoped_comptr.h View 8 chunks +11 lines, -14 lines 0 comments Download
M base/win/scoped_comptr_unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/setup/win/auth_code_getter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (16 generated)
robliao
scottmg: Please review this change. Thanks!
3 years, 7 months ago (2017-05-18 23:11:34 UTC) #5
scottmg
lgtm
3 years, 7 months ago (2017-05-18 23:13:02 UTC) #6
robliao
TBR'ing top-level directory owners for this mechanical rename. Owners: dalecurtis: media/* nicholss: remoting/* thakis: chrome/*
3 years, 7 months ago (2017-05-19 17:09:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889263002/1
3 years, 7 months ago (2017-05-19 17:10:17 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6d2438074669d3251deee6d17a9e6692ffcff297
3 years, 7 months ago (2017-05-19 17:15:41 UTC) #20
joedow
3 years, 7 months ago (2017-05-19 18:40:02 UTC) #22
Message was sent while issue was closed.
remoting lgtm

Powered by Google App Engine
This is Rietveld 408576698