Send SignalClose to the clients of P2PSocket, if TCP socket is failed to

content/renderer/p2p/ipc_socket_factory.cc

Index: content/renderer/p2p/ipc_socket_factory.cc
diff --git a/content/renderer/p2p/ipc_socket_factory.cc b/content/renderer/p2p/ipc_socket_factory.cc
index 59d94ff6837c0f04ff221ef1b51044d0a1f1bb17..4bf6d70afc91b58344c7ffdbec55bb8b33093505 100644
--- a/content/renderer/p2p/ipc_socket_factory.cc
+++ b/content/renderer/p2p/ipc_socket_factory.cc
@@ -474,6 +474,10 @@ void IpcPacketSocket::OnSendComplete() {
 
 void IpcPacketSocket::OnError() {
   DCHECK_EQ(base::MessageLoop::current(), message_loop_);
+  if (state_ == IS_OPENING) {

[Sergey Ulanov, 2014/05/16 23:49:57]

Should we also SignalClose() in the IS_OPEN state?

[Mallinath (Gone from Chromium), 2014/05/16 23:58:45]

Done.

[Mallinath (Gone from Chromium), 2014/05/16 23:58:45]

Done.

+    state_ = IS_ERROR;

[Sergey Ulanov, 2014/05/16 23:49:57]

this duplicates line 481. Maybe something like this:

  bool was_closed = state_ == IS_ERROR || state_ == IS_CLOSED;
  state_ = IS_ERROR;
  error_ = ECONNABORTED;
  if (!was_closed)
    SignalClose(this).

[Mallinath (Gone from Chromium), 2014/05/16 23:58:45]

Done.

+    SignalClose(this);
+  }
   state_ = IS_ERROR;
   error_ = ECONNABORTED;
 }