Send SignalClose to the clients of P2PSocket, if TCP socket is failed to

content/renderer/p2p/ipc_socket_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/p2p/ipc_socket_factory.h"
 
 #include <algorithm>
 #include <deque>
 
 #include "base/compiler_specific.h"
@@ skipping 456 matching lines @@
   TraceSendThrottlingState();
 
   if (writable_signal_expected_ && send_bytes_available_ > 0) {
     SignalReadyToSend(this);
     writable_signal_expected_ = false;
   }
 }
 
 void IpcPacketSocket::OnError() {
   DCHECK_EQ(base::MessageLoop::current(), message_loop_);
+  if (state_ == IS_OPENING) {

[Sergey Ulanov, 2014/05/16 23:49:57]

Should we also SignalClose() in the IS_OPEN state?

[Mallinath (Gone from Chromium), 2014/05/16 23:58:45]

Done.

[Mallinath (Gone from Chromium), 2014/05/16 23:58:45]

Done.

+    state_ = IS_ERROR;

[Sergey Ulanov, 2014/05/16 23:49:57]

this duplicates line 481. Maybe something like this:

  bool was_closed = state_ == IS_ERROR || state_ == IS_CLOSED;
  state_ = IS_ERROR;
  error_ = ECONNABORTED;
  if (!was_closed)
    SignalClose(this).

[Mallinath (Gone from Chromium), 2014/05/16 23:58:45]

Done.

+    SignalClose(this);
+  }
   state_ = IS_ERROR;
   error_ = ECONNABORTED;
 }
 
 void IpcPacketSocket::OnDataReceived(const net::IPEndPoint& address,
                                      const std::vector<char>& data,
                                      const base::TimeTicks& timestamp) {
   DCHECK_EQ(base::MessageLoop::current(), message_loop_);
 
   talk_base::SocketAddress address_lj;
@@ skipping 141 matching lines @@
 }
 
 talk_base::AsyncResolverInterface*
 IpcPacketSocketFactory::CreateAsyncResolver() {
   scoped_ptr<AsyncAddressResolverImpl> resolver(
     new AsyncAddressResolverImpl(socket_dispatcher_));
   return resolver.release();
 }
 
 }  // namespace content