Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 288923005: Improve logging of Devices and Technologies (Closed)

Created:
6 years, 7 months ago by stevenjb
Modified:
6 years, 7 months ago
Reviewers:
Ben Chan
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Improve logging of Devices and Technologies BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271807

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + use const_iterator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M chromeos/dbus/fake_shill_device_client.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chromeos/network/shill_property_handler.cc View 1 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stevenjb
6 years, 7 months ago (2014-05-15 18:23:37 UTC) #1
Ben Chan
lgtm https://codereview.chromium.org/288923005/diff/1/chromeos/network/network_state_handler.cc File chromeos/network/network_state_handler.cc (right): https://codereview.chromium.org/288923005/diff/1/chromeos/network/network_state_handler.cc#newcode695 chromeos/network/network_state_handler.cc:695: for (ManagedStateList::iterator iter = device_list_.begin(); can it be ...
6 years, 7 months ago (2014-05-15 22:56:45 UTC) #2
stevenjb
https://codereview.chromium.org/288923005/diff/1/chromeos/network/network_state_handler.cc File chromeos/network/network_state_handler.cc (right): https://codereview.chromium.org/288923005/diff/1/chromeos/network/network_state_handler.cc#newcode695 chromeos/network/network_state_handler.cc:695: for (ManagedStateList::iterator iter = device_list_.begin(); On 2014/05/15 22:56:45, Ben ...
6 years, 7 months ago (2014-05-20 18:27:24 UTC) #3
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 7 months ago (2014-05-20 18:27:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/288923005/20001
6 years, 7 months ago (2014-05-20 18:28:49 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 01:59:52 UTC) #6
Message was sent while issue was closed. 
Change committed as 271807

Powered by Google App Engine
This is Rietveld 408576698