Improve logging of Devices and Technologies

chromeos/network/network_state_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_state_handler.h"
 
 #include "base/bind.h"
 #include "base/format_macros.h"
 #include "base/location.h"
 #include "base/logging.h"
@@ skipping 673 matching lines @@
       if (!favorite->IsFavorite())
         continue;
       if (favorite->IsPrivate())
         ++unshared;
       else
         ++shared;
     }
     UMA_HISTOGRAM_COUNTS_100("Networks.RememberedShared", shared);
     UMA_HISTOGRAM_COUNTS_100("Networks.RememberedUnshared", unshared);
   } else if (type == ManagedState::MANAGED_TYPE_DEVICE) {
+    std::string devices;
+    for (ManagedStateList::iterator iter = device_list_.begin();

[Ben Chan, 2014/05/15 22:56:45]

can it be const_iterator?

[stevenjb, 2014/05/20 18:27:24]

Done.

+         iter != device_list_.end(); ++iter) {
+      if (iter != device_list_.begin())
+        devices += ", ";
+      devices += (*iter)->name();
+    }
+    NET_LOG_EVENT("DeviceList:", devices);
     NotifyDeviceListChanged();
   } else {
     NOTREACHED();
   }
 }
 
 void NetworkStateHandler::DefaultNetworkServiceChanged(
     const std::string& service_path) {
   // Shill uses '/' for empty service path values; check explicitly for that.
   const char* kEmptyServicePath = "/";
@@ skipping 158 matching lines @@
   if (type.MatchesType(shill::kTypeBluetooth))
     technologies.push_back(new std::string(shill::kTypeBluetooth));
   if (type.MatchesType(shill::kTypeVPN))
     technologies.push_back(new std::string(shill::kTypeVPN));
 
   CHECK_GT(technologies.size(), 0ul);
   return technologies.Pass();
 }
 
 }  // namespace chromeos