Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4529)

Unified Diff: chrome/browser/extensions/proxy_overridden_bubble_controller.h

Issue 288923004: Add an extension override bubble and warning box for proxy extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/proxy_overridden_bubble_controller.h
diff --git a/chrome/browser/extensions/proxy_overridden_bubble_controller.h b/chrome/browser/extensions/proxy_overridden_bubble_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..563be28bdf2b94e1ae3ea3ba8abc465179c6e316
--- /dev/null
+++ b/chrome/browser/extensions/proxy_overridden_bubble_controller.h
@@ -0,0 +1,35 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
Devlin 2014/05/20 17:26:31 nit: no (c) anymore.
Finnur 2014/05/21 16:30:32 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_PROXY_OVERRIDDEN_BUBBLE_CONTROLLER_H_
+#define CHROME_BROWSER_EXTENSIONS_PROXY_OVERRIDDEN_BUBBLE_CONTROLLER_H_
+
+#include <string>
Devlin 2014/05/20 17:26:31 nit: I think there's supposed to be a newline betw
Finnur 2014/05/21 16:30:32 Done.
+#include "chrome/browser/extensions/extension_message_bubble_controller.h"
+
+namespace extensions {
+
+class ProxyOverriddenBubbleController
+ : public extensions::ExtensionMessageBubbleController {
Devlin 2014/05/20 17:26:31 nit: no extensions:: prefix.
Finnur 2014/05/21 16:30:32 Done.
+ public:
+ explicit ProxyOverriddenBubbleController(Profile* profile);
+ virtual ~ProxyOverriddenBubbleController();
+
+ // Whether the controller knows that we should show the bubble for extension
+ // with |extension_id|. Returns true if so.
+ bool ShouldShow(const std::string& extension_id);
+
+ // ExtensionMessageBubbleController:
+ virtual bool CloseOnDeactivate() OVERRIDE;
+
+ private:
+ // A weak pointer to the profile we are associated with. Not owned by us.
+ Profile* profile_;
+
+ DISALLOW_COPY_AND_ASSIGN(ProxyOverriddenBubbleController);
+};
+
+} // namespace extensions
+
+#endif // CHROME_BROWSER_EXTENSIONS_PROXY_OVERRIDDEN_BUBBLE_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698