Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: chrome/browser/extensions/proxy_overridden_bubble_controller.h

Issue 288923004: Add an extension override bubble and warning box for proxy extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
Devlin 2014/05/20 17:26:31 nit: no (c) anymore.
Finnur 2014/05/21 16:30:32 Done.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_EXTENSIONS_PROXY_OVERRIDDEN_BUBBLE_CONTROLLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_PROXY_OVERRIDDEN_BUBBLE_CONTROLLER_H_
7
8 #include <string>
Devlin 2014/05/20 17:26:31 nit: I think there's supposed to be a newline betw
Finnur 2014/05/21 16:30:32 Done.
9 #include "chrome/browser/extensions/extension_message_bubble_controller.h"
10
11 namespace extensions {
12
13 class ProxyOverriddenBubbleController
14 : public extensions::ExtensionMessageBubbleController {
Devlin 2014/05/20 17:26:31 nit: no extensions:: prefix.
Finnur 2014/05/21 16:30:32 Done.
15 public:
16 explicit ProxyOverriddenBubbleController(Profile* profile);
17 virtual ~ProxyOverriddenBubbleController();
18
19 // Whether the controller knows that we should show the bubble for extension
20 // with |extension_id|. Returns true if so.
21 bool ShouldShow(const std::string& extension_id);
22
23 // ExtensionMessageBubbleController:
24 virtual bool CloseOnDeactivate() OVERRIDE;
25
26 private:
27 // A weak pointer to the profile we are associated with. Not owned by us.
28 Profile* profile_;
29
30 DISALLOW_COPY_AND_ASSIGN(ProxyOverriddenBubbleController);
31 };
32
33 } // namespace extensions
34
35 #endif // CHROME_BROWSER_EXTENSIONS_PROXY_OVERRIDDEN_BUBBLE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698