Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2889213004: Use seperate expected files for fast/frames/set-parent-src-synchronously.{html,xhtml} (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9, kojii
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use seperate expected files for fast/frames/set-parent-src-synchronously.{html,xhtml} The two layout tests fast/frames/set-parent-src-synchronously.html and fast/frames/set-parent-src-synchronously.xhtml have (slightly) different behaviors but share the same expected file. This patch renames the two tests so that they use separate expected files, so that potential test flakiness is reduced. BUG=n/a Review-Url: https://codereview.chromium.org/2889213004 Cr-Commit-Position: refs/heads/master@{#473134} Committed: https://chromium.googlesource.com/chromium/src/+/19a83f8917e6a6df07d91cdaf3db4dc256f82390

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
Xiaocheng
PTAL. It seems to be a layout bug (or feature?) that whitespace collapsing is done ...
3 years, 7 months ago (2017-05-19 07:21:24 UTC) #5
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-19 07:41:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889213004/1
3 years, 7 months ago (2017-05-19 07:56:40 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 09:07:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/19a83f8917e6a6df07d91cdaf3db...

Powered by Google App Engine
This is Rietveld 408576698