Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2889193003: [subresource_filter] Reland: Remove Forwarding NavigationThrottles (Closed)

Created:
3 years, 7 months ago by Charlie Harrison
Modified:
3 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[subresource_filter] Reland: Remove Forwarding NavigationThrottles This originally landed in [1] but was reverted due to an improper call to vector::back() on an empty vector. This leads to undefined behavior. [1]: https://codereview.chromium.org/2889913002/ TBR=creis@chromium.org BUG=708181 Review-Url: https://codereview.chromium.org/2889193003 Cr-Commit-Position: refs/heads/master@{#473190} Committed: https://chromium.googlesource.com/chromium/src/+/f367375ce101bdb6a376d441774044d9fc8a3009

Patch Set 1 : Original Patch set #

Patch Set 2 : Fix #

Messages

Total messages: 19 (15 generated)
Charlie Harrison
Shivani: PTAL at this fix. PS1 is the original patch so feel free to check ...
3 years, 7 months ago (2017-05-19 11:45:53 UTC) #6
shivanisha
On 2017/05/19 11:45:53, Charlie Harrison wrote: > Shivani: PTAL at this fix. PS1 is the ...
3 years, 7 months ago (2017-05-19 13:33:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889193003/20001
3 years, 7 months ago (2017-05-19 13:35:23 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 14:59:06 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f367375ce101bdb6a376d4417740...

Powered by Google App Engine
This is Rietveld 408576698