Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2889173003: [NTP Favicons] Add testing config for two features for fetching icons. (Closed)

Created:
3 years, 7 months ago by jkrcal
Modified:
3 years, 7 months ago
Reviewers:
rkaplow
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Favicons] Add testing config for two features for fetching icons. BUG=714109, 695810 Review-Url: https://codereview.chromium.org/2889173003 Cr-Commit-Position: refs/heads/master@{#473426} Committed: https://chromium.googlesource.com/chromium/src/+/a8acbe5b8351591685b0353437651d8bdc2d42df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jkrcal
Robert, could you PTAL?
3 years, 7 months ago (2017-05-19 12:02:12 UTC) #2
rkaplow
lgtm
3 years, 7 months ago (2017-05-19 20:19:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889173003/1
3 years, 7 months ago (2017-05-20 07:02:53 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 08:02:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8acbe5b8351591685b035343765...

Powered by Google App Engine
This is Rietveld 408576698