Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: components/autofill/core/browser/autofill_address_util.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_address_util.cc
diff --git a/components/autofill/core/browser/autofill_address_util.cc b/components/autofill/core/browser/autofill_address_util.cc
index c232e0026513379e93b646177282b74d02c7b41f..1c6cee13a5b96ff20c500b1a858bd2e27be2b940 100644
--- a/components/autofill/core/browser/autofill_address_util.cc
+++ b/components/autofill/core/browser/autofill_address_util.cc
@@ -148,7 +148,7 @@ void SetCountryData(const PersonalDataManager& manager,
"value", countries[i] ? countries[i]->country_code() : "separator");
country_list->Append(std::move(option_details));
}
- localized_strings->Set("autofillCountrySelectList", country_list.release());
+ localized_strings->Set("autofillCountrySelectList", std::move(country_list));
std::unique_ptr<base::ListValue> default_country_components(
new base::ListValue);
@@ -157,7 +157,7 @@ void SetCountryData(const PersonalDataManager& manager,
default_country_components.get(),
&default_country_language_code);
localized_strings->Set("autofillDefaultCountryComponents",
- default_country_components.release());
+ std::move(default_country_components));
localized_strings->SetString("autofillDefaultCountryLanguageCode",
default_country_language_code);
}

Powered by Google App Engine
This is Rietveld 408576698