Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2150)

Unified Diff: chrome/browser/bookmarks/bookmark_html_writer.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_html_writer.cc
diff --git a/chrome/browser/bookmarks/bookmark_html_writer.cc b/chrome/browser/bookmarks/bookmark_html_writer.cc
index 5bfecb94303cda68a4b3810baf2c4e3b257a93fe..2ebc2621949aa5cae8166b75084bacc2d51b5bc1 100644
--- a/chrome/browser/bookmarks/bookmark_html_writer.cc
+++ b/chrome/browser/bookmarks/bookmark_html_writer.cc
@@ -96,15 +96,14 @@ const size_t kIndentSize = 4;
// Class responsible for the actual writing. Takes ownership of favicons_map.
class Writer : public base::RefCountedThreadSafe<Writer> {
public:
- Writer(base::Value* bookmarks,
+ Writer(std::unique_ptr<base::Value> bookmarks,
const base::FilePath& path,
BookmarkFaviconFetcher::URLFaviconMap* favicons_map,
BookmarksExportObserver* observer)
- : bookmarks_(bookmarks),
+ : bookmarks_(std::move(bookmarks)),
path_(path),
favicons_map_(favicons_map),
- observer_(observer) {
- }
+ observer_(observer) {}
// Writing bookmarks and favicons data to file.
void DoWrite() {

Powered by Google App Engine
This is Rietveld 408576698