[NTP::SectionOrder] Add ranker section to snippets internals.

[NTP::SectionOrder] Add ranker section to snippets internals.

Previously, it was cumbersome to verify whether ranker works (due to
implicity of its effects). This CL adds some ranker debug output to
snippets internals.

The screenshots are in the bug.

BUG=723622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889153003
Cr-Commit-Position: refs/heads/master@{#472847}
Committed: https://chromium.googlesource.com/chromium/src/+/147728249280f6259c9143a91d878408b4c8e5a2

[vitaliii, 2017-05-18 11:58:44]

Description was changed from

==========
[NTP::SectionOrder] Add ranker section to snippets internals.

Previously, it was cumbersome to verify whether ranker works (due to
implicity of its effects). This CL adds some ranker debug output to
snippets internals.

The screenshots are in the bug.

BUG=723622
==========

to

==========
[NTP::SectionOrder] Add ranker section to snippets internals.

Previously, it was cumbersome to verify whether ranker works (due to
implicity of its effects). This CL adds some ranker debug output to
snippets internals.

The screenshots are in the bug.

BUG=723622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[vitaliii, 2017-05-18 12:07:16]

Patchset #1 (id:1) has been deleted

[vitaliii, 2017-05-18 12:07:36]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[vitaliii, 2017-05-18 12:08:05]

vitaliii@chromium.org changed reviewers:
+ jkrcal@chromium.org

[vitaliii, 2017-05-18 12:08:06]

Hi jkrcal@,

Could you have a look please?

[commit-bot: I haz the power, 2017-05-18 12:08:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkrcal, 2017-05-18 12:16:58]

lgtm

https://codereview.chromium.org/2889153003/diff/20001/components/ntp_snippets...
File components/ntp_snippets/category_rankers/constant_category_ranker.cc
(right):

https://codereview.chromium.org/2889153003/diff/20001/components/ntp_snippets...
components/ntp_snippets/category_rankers/constant_category_ranker.cc:99: if
(!first) {
nit: maybe you can simplify the code using base::JoinString? 
(The same for the other GetDebugData function)

[vitaliii, 2017-05-18 13:00:21]

Patchset #2 (id:40001) has been deleted

[vitaliii, 2017-05-18 13:00:50]

I've addressed your nit, no need to look.

https://codereview.chromium.org/2889153003/diff/20001/components/ntp_snippets...
File components/ntp_snippets/category_rankers/constant_category_ranker.cc
(right):

https://codereview.chromium.org/2889153003/diff/20001/components/ntp_snippets...
components/ntp_snippets/category_rankers/constant_category_ranker.cc:99: if
(!first) {
On 2017/05/18 12:16:58, jkrcal wrote:
> nit: maybe you can simplify the code using base::JoinString? 
> (The same for the other GetDebugData function)

Done.

[vitaliii, 2017-05-18 13:01:58]

The CQ bit was checked by vitaliii@chromium.org

[vitaliii, 2017-05-18 13:01:58]

The patchset sent to the CQ was uploaded after l-g-t-m from jkrcal@chromium.org
Link to the patchset: https://codereview.chromium.org/2889153003/#ps60001
(title: "jkrcal@ nit.")

[commit-bot: I haz the power, 2017-05-18 13:02:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 15:16:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 15:16:52]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vitaliii, 2017-05-18 15:20:48]

The CQ bit was checked by vitaliii@chromium.org

[commit-bot: I haz the power, 2017-05-18 15:21:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 16:53:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495120848355540,
"parent_rev": "1b3799fee23bfbfc578c184236a4b3f663509f95", "commit_rev":
"147728249280f6259c9143a91d878408b4c8e5a2"}

[commit-bot: I haz the power, 2017-05-18 16:53:25]

Description was changed from

==========
[NTP::SectionOrder] Add ranker section to snippets internals.

Previously, it was cumbersome to verify whether ranker works (due to
implicity of its effects). This CL adds some ranker debug output to
snippets internals.

The screenshots are in the bug.

BUG=723622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[NTP::SectionOrder] Add ranker section to snippets internals.

Previously, it was cumbersome to verify whether ranker works (due to
implicity of its effects). This CL adds some ranker debug output to
snippets internals.

The screenshots are in the bug.

BUG=723622
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2889153003
Cr-Commit-Position: refs/heads/master@{#472847}
Committed:
https://chromium.googlesource.com/chromium/src/+/147728249280f6259c9143a91d87...
==========

[commit-bot: I haz the power, 2017-05-18 16:53:28]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/147728249280f6259c9143a91d87...