Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2889123003: Remove SetOverscrollEnabledWithAccessibilityKeyboard(). (Closed)

Created:
3 years, 7 months ago by yhanada
Modified:
3 years, 7 months ago
Reviewers:
sadrul, oshima
CC:
chromium-reviews, blakeo+virtualkb_chromium.org, sadrul, oka+watchvk_chromium.org, yhanada+watchvk_chromium.org, kalyank, dfaden+virtualkb_google.com, groby+virtualkb_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SetOverscrollEnabledWithAccessibilityKeyboard(). This method is no longer needed after new window behavior for the accessibility keyboard is introduced. It's introduced in crrev.com/2553603002 and enabled by default by crrev.com/2869273007. BUG=624521, 696436 TEST=Manual. Resizing of Android app's window doesn't happen when the accessibility keyboard shows up. Review-Url: https://codereview.chromium.org/2889123003 Cr-Commit-Position: refs/heads/master@{#473020} Committed: https://chromium.googlesource.com/chromium/src/+/d3932e83e4d948d982d181fa79b166bc36f4f5d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M ash/virtual_keyboard_controller.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
yhanada
PTAL. Thanks!
3 years, 7 months ago (2017-05-18 08:23:00 UTC) #4
oshima
lgtm
3 years, 7 months ago (2017-05-18 08:29:26 UTC) #5
sadrul
lgtm
3 years, 7 months ago (2017-05-18 14:26:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889123003/1
3 years, 7 months ago (2017-05-19 01:24:24 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 01:38:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3932e83e4d948d982d181fa79b1...

Powered by Google App Engine
This is Rietveld 408576698