Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.html

Issue 2889073002: Settings: Internet page cleanup (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/internet_detail_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/internet_page/internet_detail_page.html
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.html b/chrome/browser/resources/settings/internet_page/internet_detail_page.html
index edd385be16c4574b2dfb7defda628184dc4c268e..42bbb0dc9894f4a769ebb24b91c4255a0669620d 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.html
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.html
@@ -32,10 +32,6 @@
padding-bottom: 40px;
}
- cr-network-icon {
- -webkit-padding-end: 8px;
- }
-
iron-collapse {
margin: 10px 0;
}
@@ -65,17 +61,7 @@
border-top: none;
}
- #buttonDiv paper-button {
- /* Align text edge with trailing margin (12px button padding) */
- -webkit-margin-end: -12px;
- /* 8px spacing between highlight edges. */
- -webkit-margin-start: calc(12px + 8px);
- margin-bottom: 10px;
- margin-top: 10px;
- }
-
#networkState {
- -webkit-padding-start: 8px;
font-size: 107.69%; /* 14px / 13px */
font-weight: 500;
}
@@ -101,7 +87,7 @@
</cr-policy-indicator>
</template>
</div>
- <div id="buttonDiv" class="layout horizontal center">
+ <div id="buttonDiv" class="button-container">
<template is="dom-if" if="[[!isSecondaryUser_]]">
<paper-button class="secondary-button" on-tap="onForgetTap_"
hidden$="[[!showForget_(networkProperties)]]">
@@ -189,8 +175,7 @@
</div>
</template>
<!-- Data roaming (Cellular only). -->
- <template is="dom-if"
- if="[[isType_(NetworkType_.CELLULAR, networkProperties)]]">
+ <template is="dom-if" if="[[isCellular_(networkProperties)]]">
<div class="settings-box">
<settings-toggle-button id="allowDataRoaming" class="start"
pref="{{prefs.cros.signed.data_roaming_enabled}}"
@@ -269,8 +254,7 @@
<iron-collapse opened="[[networkExpanded_]]">
<div class="layout vertical indented">
<!-- APN -->
- <template is="dom-if"
- if="[[isType_(NetworkType_.CELLULAR, networkProperties)]]">
+ <template is="dom-if" if="[[isCellular_(networkProperties)]]">
<network-apnlist editable on-apn-change="onNetworkPropertyChange_"
network-properties="[[networkProperties]]">
</network-apnlist>
@@ -299,10 +283,12 @@
</div>
<iron-collapse opened="[[proxyExpanded_]]">
- <network-proxy editable prefs="{{prefs}}"
- on-proxy-change="onProxyChange_"
- network-properties="[[networkProperties]]">
- </network-proxy>
+ <div class="layout vertical indented">
+ <network-proxy editable prefs="{{prefs}}"
+ on-proxy-change="onProxyChange_"
+ network-properties="[[networkProperties]]">
+ </network-proxy>
+ </div>
</iron-collapse>
</template>
</template>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/internet_detail_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698