Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.html

Issue 2889073002: Settings: Internet page cleanup (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/internet_detail_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 2
3 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html"> 3 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">
4 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 4 <link rel="import" href="chrome://resources/cr_elements/icons.html">
5 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_icon. html"> 5 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_icon. html">
6 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.htm l"> 6 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.htm l">
7 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_indicat or.html"> 7 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_indicat or.html">
8 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network _behavior.html"> 8 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network _behavior.html">
9 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network _indicator.html"> 9 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network _indicator.html">
10 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 10 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
(...skipping 14 matching lines...) Expand all
25 <link rel="import" href="network_siminfo.html"> 25 <link rel="import" href="network_siminfo.html">
26 <link rel="import" href="tether_connection_dialog.html"> 26 <link rel="import" href="tether_connection_dialog.html">
27 27
28 <dom-module id="settings-internet-detail-page"> 28 <dom-module id="settings-internet-detail-page">
29 <template> 29 <template>
30 <style include="internet-shared iron-flex"> 30 <style include="internet-shared iron-flex">
31 :host { 31 :host {
32 padding-bottom: 40px; 32 padding-bottom: 40px;
33 } 33 }
34 34
35 cr-network-icon {
36 -webkit-padding-end: 8px;
37 }
38
39 iron-collapse { 35 iron-collapse {
40 margin: 10px 0; 36 margin: 10px 0;
41 } 37 }
42 38
43 iron-icon { 39 iron-icon {
44 -webkit-margin-end: 10px; 40 -webkit-margin-end: 10px;
45 } 41 }
46 42
47 paper-toggle-button { 43 paper-toggle-button {
48 -webkit-margin-start: var(--settings-control-label-spacing); 44 -webkit-margin-start: var(--settings-control-label-spacing);
49 } 45 }
50 46
51 cr-policy-network-indicator, 47 cr-policy-network-indicator,
52 cr-policy-indicator { 48 cr-policy-indicator {
53 -webkit-margin-start: var(--settings-controlled-by-spacing); 49 -webkit-margin-start: var(--settings-controlled-by-spacing);
54 } 50 }
55 51
56 .indented { 52 .indented {
57 -webkit-margin-start: var(--settings-box-row-padding); 53 -webkit-margin-start: var(--settings-box-row-padding);
58 } 54 }
59 55
60 .settings-box.stretch { 56 .settings-box.stretch {
61 align-items: stretch; 57 align-items: stretch;
62 } 58 }
63 59
64 .settings-box:first-of-type { 60 .settings-box:first-of-type {
65 border-top: none; 61 border-top: none;
66 } 62 }
67 63
68 #buttonDiv paper-button {
69 /* Align text edge with trailing margin (12px button padding) */
70 -webkit-margin-end: -12px;
71 /* 8px spacing between highlight edges. */
72 -webkit-margin-start: calc(12px + 8px);
73 margin-bottom: 10px;
74 margin-top: 10px;
75 }
76
77 #networkState { 64 #networkState {
78 -webkit-padding-start: 8px;
79 font-size: 107.69%; /* 14px / 13px */ 65 font-size: 107.69%; /* 14px / 13px */
80 font-weight: 500; 66 font-weight: 500;
81 } 67 }
82 68
83 #networkState[connected] { 69 #networkState[connected] {
84 color: var(--google-green-500); 70 color: var(--google-green-500);
85 } 71 }
86 </style> 72 </style>
87 <!-- Title section: Icon + name + connection state. --> 73 <!-- Title section: Icon + name + connection state. -->
88 <div class="settings-box first"> 74 <div class="settings-box first">
89 <div class="start layout horizontal center"> 75 <div class="start layout horizontal center">
90 <cr-network-icon network-state="[[networkProperties]]"> 76 <cr-network-icon network-state="[[networkProperties]]">
91 </cr-network-icon> 77 </cr-network-icon>
92 <div id="networkState" 78 <div id="networkState"
93 connected$="[[isConnectedState_(networkProperties)]]"> 79 connected$="[[isConnectedState_(networkProperties)]]">
94 [[getStateText_(networkProperties)]] 80 [[getStateText_(networkProperties)]]
95 </div> 81 </div>
96 <template is="dom-if" 82 <template is="dom-if"
97 if="[[isPolicySource(networkProperties.Source))]]"> 83 if="[[isPolicySource(networkProperties.Source))]]">
98 <cr-policy-indicator 84 <cr-policy-indicator
99 indicator-type="[[getIndicatorTypeForSource( 85 indicator-type="[[getIndicatorTypeForSource(
100 networkProperties.Source)]]"> 86 networkProperties.Source)]]">
101 </cr-policy-indicator> 87 </cr-policy-indicator>
102 </template> 88 </template>
103 </div> 89 </div>
104 <div id="buttonDiv" class="layout horizontal center"> 90 <div id="buttonDiv" class="button-container">
105 <template is="dom-if" if="[[!isSecondaryUser_]]"> 91 <template is="dom-if" if="[[!isSecondaryUser_]]">
106 <paper-button class="secondary-button" on-tap="onForgetTap_" 92 <paper-button class="secondary-button" on-tap="onForgetTap_"
107 hidden$="[[!showForget_(networkProperties)]]"> 93 hidden$="[[!showForget_(networkProperties)]]">
108 $i18n{networkButtonForget} 94 $i18n{networkButtonForget}
109 </paper-button> 95 </paper-button>
110 <paper-button class="secondary-button" on-tap="onViewAccountTap_" 96 <paper-button class="secondary-button" on-tap="onViewAccountTap_"
111 hidden$="[[!showViewAccount_(networkProperties)]]"> 97 hidden$="[[!showViewAccount_(networkProperties)]]">
112 $i18n{networkButtonViewAccount} 98 $i18n{networkButtonViewAccount}
113 </paper-button> 99 </paper-button>
114 <paper-button class="secondary-button" on-tap="onActivateTap_" 100 <paper-button class="secondary-button" on-tap="onActivateTap_"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 property="[[getManagedAutoConnect_(networkProperties)]]"> 168 property="[[getManagedAutoConnect_(networkProperties)]]">
183 </cr-policy-network-indicator> 169 </cr-policy-network-indicator>
184 <paper-toggle-button checked="{{autoConnect_}}" 170 <paper-toggle-button checked="{{autoConnect_}}"
185 disabled="[[!enableAutoConnect_(networkProperties, 171 disabled="[[!enableAutoConnect_(networkProperties,
186 globalPolicy)]]" 172 globalPolicy)]]"
187 aria-labelledby="autoConnectToggleLabel"> 173 aria-labelledby="autoConnectToggleLabel">
188 </paper-toggle-button> 174 </paper-toggle-button>
189 </div> 175 </div>
190 </template> 176 </template>
191 <!-- Data roaming (Cellular only). --> 177 <!-- Data roaming (Cellular only). -->
192 <template is="dom-if" 178 <template is="dom-if" if="[[isCellular_(networkProperties)]]">
193 if="[[isType_(NetworkType_.CELLULAR, networkProperties)]]">
194 <div class="settings-box"> 179 <div class="settings-box">
195 <settings-toggle-button id="allowDataRoaming" class="start" 180 <settings-toggle-button id="allowDataRoaming" class="start"
196 pref="{{prefs.cros.signed.data_roaming_enabled}}" 181 pref="{{prefs.cros.signed.data_roaming_enabled}}"
197 label="$i18n{networkAllowDataRoaming}"> 182 label="$i18n{networkAllowDataRoaming}">
198 </settings-toggle-button> 183 </settings-toggle-button>
199 </div> 184 </div>
200 </template> 185 </template>
201 <!-- SIM Info (Cellular only). --> 186 <!-- SIM Info (Cellular only). -->
202 <template is="dom-if" if="[[showCellularSim_(networkProperties)]]"> 187 <template is="dom-if" if="[[showCellularSim_(networkProperties)]]">
203 <div class="settings-box single-column stretch"> 188 <div class="settings-box single-column stretch">
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 <div class="settings-box" actionable on-tap="toggleNetworkExpanded_"> 247 <div class="settings-box" actionable on-tap="toggleNetworkExpanded_">
263 <div class="start">$i18n{networkSectionNetwork}</div> 248 <div class="start">$i18n{networkSectionNetwork}</div>
264 <cr-expand-button expanded="{{networkExpanded_}}" 249 <cr-expand-button expanded="{{networkExpanded_}}"
265 alt="$i18n{networkSectionNetworkExpandA11yLabel}"> 250 alt="$i18n{networkSectionNetworkExpandA11yLabel}">
266 </cr-expand-button> 251 </cr-expand-button>
267 </div> 252 </div>
268 253
269 <iron-collapse opened="[[networkExpanded_]]"> 254 <iron-collapse opened="[[networkExpanded_]]">
270 <div class="layout vertical indented"> 255 <div class="layout vertical indented">
271 <!-- APN --> 256 <!-- APN -->
272 <template is="dom-if" 257 <template is="dom-if" if="[[isCellular_(networkProperties)]]">
273 if="[[isType_(NetworkType_.CELLULAR, networkProperties)]]">
274 <network-apnlist editable on-apn-change="onNetworkPropertyChange_" 258 <network-apnlist editable on-apn-change="onNetworkPropertyChange_"
275 network-properties="[[networkProperties]]"> 259 network-properties="[[networkProperties]]">
276 </network-apnlist> 260 </network-apnlist>
277 </template> 261 </template>
278 262
279 <!-- IP Config, Nameservers --> 263 <!-- IP Config, Nameservers -->
280 <template is="dom-if" 264 <template is="dom-if"
281 if="[[isRememberedOrConnected_(networkProperties)]]"> 265 if="[[isRememberedOrConnected_(networkProperties)]]">
282 <network-ip-config editable on-ip-change="onIPConfigChange_" 266 <network-ip-config editable on-ip-change="onIPConfigChange_"
283 network-properties="[[networkProperties]]"> 267 network-properties="[[networkProperties]]">
284 </network-ip-config> 268 </network-ip-config>
285 <network-nameservers editable 269 <network-nameservers editable
286 on-nameservers-change="onIPConfigChange_" 270 on-nameservers-change="onIPConfigChange_"
287 network-properties="[[networkProperties]]"> 271 network-properties="[[networkProperties]]">
288 </network-nameservers> 272 </network-nameservers>
289 </template> 273 </template>
290 </div> 274 </div>
291 </iron-collapse> 275 </iron-collapse>
292 276
293 <!-- Proxy toggle --> 277 <!-- Proxy toggle -->
294 <div class="settings-box" actionable on-tap="toggleProxyExpanded_"> 278 <div class="settings-box" actionable on-tap="toggleProxyExpanded_">
295 <div class="start">$i18n{networkSectionProxy}</div> 279 <div class="start">$i18n{networkSectionProxy}</div>
296 <cr-expand-button expanded="{{proxyExpanded_}}" 280 <cr-expand-button expanded="{{proxyExpanded_}}"
297 alt="$i18n{networkSectionProxyExpandA11yLabel}"> 281 alt="$i18n{networkSectionProxyExpandA11yLabel}">
298 </cr-expand-button> 282 </cr-expand-button>
299 </div> 283 </div>
300 284
301 <iron-collapse opened="[[proxyExpanded_]]"> 285 <iron-collapse opened="[[proxyExpanded_]]">
302 <network-proxy editable prefs="{{prefs}}" 286 <div class="layout vertical indented">
303 on-proxy-change="onProxyChange_" 287 <network-proxy editable prefs="{{prefs}}"
304 network-properties="[[networkProperties]]"> 288 on-proxy-change="onProxyChange_"
305 </network-proxy> 289 network-properties="[[networkProperties]]">
290 </network-proxy>
291 </div>
306 </iron-collapse> 292 </iron-collapse>
307 </template> 293 </template>
308 </template> 294 </template>
309 295
310 <tether-connection-dialog id="tetherDialog" 296 <tether-connection-dialog id="tetherDialog"
311 network-properties="[[networkProperties]]" 297 network-properties="[[networkProperties]]"
312 on-tether-connect="onTetherConnect_" 298 on-tether-connect="onTetherConnect_"
313 on-close="onTetherDialogClose_"> 299 on-close="onTetherDialogClose_">
314 </tether-connection-dialog> 300 </tether-connection-dialog>
315 </template> 301 </template>
316 <script src="internet_detail_page.js"></script> 302 <script src="internet_detail_page.js"></script>
317 </dom-module> 303 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/internet_detail_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698