Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2889053002: [ObjC ARC] Converts ios/chrome/browser/test:perf_test_support to ARC. (Closed)

Created:
3 years, 7 months ago by liaoyuke
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/test:perf_test_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2889053002 Cr-Commit-Position: refs/heads/master@{#473569} Committed: https://chromium.googlesource.com/chromium/src/+/a7da4fb9c6de1f8f9f4762f608d5b20e6b9d56dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/test/perf_test_with_bvc_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
liaoyuke
Hi Sylvain, PTAL. Thank you very much!
3 years, 7 months ago (2017-05-18 17:57:25 UTC) #6
sdefresne
lgtm
3 years, 7 months ago (2017-05-22 11:55:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889053002/1
3 years, 7 months ago (2017-05-22 11:56:03 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 13:34:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7da4fb9c6de1f8f9f4762f608d5...

Powered by Google App Engine
This is Rietveld 408576698