Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 2888993003: [ObjC ARC] Converts ios/chrome/browser/ui/material_components:material_components to ARC. (Closed)

Created:
3 years, 7 months ago by lindsayw
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/material_components:material_components to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2888993003 Cr-Commit-Position: refs/heads/master@{#476339} Committed: https://chromium.googlesource.com/chromium/src/+/862a0c176b2b191cee78bd82db01bf6531d299ba

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding strong classifier to app_bar_presenting.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M ios/chrome/browser/ui/material_components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/material_components/activity_indicator.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/material_components/app_bar_presenting.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/material_components/utils.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
lindsayw
Thanks for your review!
3 years, 7 months ago (2017-05-19 14:08:42 UTC) #10
lindsayw
Hi Rohit, Can you please review since Paris is out and you are owner? Thanks,
3 years, 7 months ago (2017-05-25 14:32:47 UTC) #12
stkhapugin
lgtm with comments https://codereview.chromium.org/2888993003/diff/1/ios/chrome/browser/ui/material_components/BUILD.gn File ios/chrome/browser/ui/material_components/BUILD.gn (right): https://codereview.chromium.org/2888993003/diff/1/ios/chrome/browser/ui/material_components/BUILD.gn#newcode10 ios/chrome/browser/ui/material_components/BUILD.gn:10: "app_bar_presenting.h", In this header, please add ...
3 years, 6 months ago (2017-05-30 13:49:53 UTC) #15
lindsayw
https://codereview.chromium.org/2888993003/diff/1/ios/chrome/browser/ui/material_components/BUILD.gn File ios/chrome/browser/ui/material_components/BUILD.gn (right): https://codereview.chromium.org/2888993003/diff/1/ios/chrome/browser/ui/material_components/BUILD.gn#newcode10 ios/chrome/browser/ui/material_components/BUILD.gn:10: "app_bar_presenting.h", On 2017/05/30 13:49:53, stkhapugin wrote: > In this ...
3 years, 6 months ago (2017-06-01 14:54:32 UTC) #16
rohitrao (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-01 17:25:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888993003/20001
3 years, 6 months ago (2017-06-01 17:28:38 UTC) #24
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 17:33:22 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/862a0c176b2b191cee78bd82db01...

Powered by Google App Engine
This is Rietveld 408576698