Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2888983003: chromeos: Remove ash::SystemTrayDelegate::CreateTrayRotationLock (Closed)

Created:
3 years, 7 months ago by James Cook
Modified:
3 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove ash::SystemTrayDelegate::CreateTrayRotationLock This exists for mash. It was added before ash::Shell::GetAshConfig existed. It doesn't need to be on the ash-to-chrome delegate. BUG=647412 TEST=ash_unittests, manual test of chrome --mus and --mash by entering touch-view mode with Ctrl-Alt-Shift-T Review-Url: https://codereview.chromium.org/2888983003 Cr-Commit-Position: refs/heads/master@{#472921} Committed: https://chromium.googlesource.com/chromium/src/+/0ea8cc012d4771fb1f418d5f9a266285e9c286f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -34 lines) Patch
M ash/system/tray/system_tray.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 3 chunks +0 lines, -12 lines 0 comments Download
M ash/system/tray/system_tray_delegate.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
James Cook
msw, please take a look.
3 years, 7 months ago (2017-05-18 18:27:46 UTC) #3
msw
nice! lgtm
3 years, 7 months ago (2017-05-18 20:31:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888983003/1
3 years, 7 months ago (2017-05-18 20:36:51 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 20:46:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ea8cc012d4771fb1f418d5f9a26...

Powered by Google App Engine
This is Rietveld 408576698