Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2888973002: [VrShell] Mask system ui flags before checking. (Closed)

Created:
3 years, 7 months ago by amp
Modified:
3 years, 7 months ago
Reviewers:
mthiesse
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[VrShell] Mask system ui flags before checking. This fixes an issue where extraneous flags were being set on some devices and causing the flag check to fail. BUG=719013 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2881403003 Cr-Original-Commit-Position: refs/heads/master@{#472257} Review-Url: https://codereview.chromium.org/2888973002 Cr-Commit-Position: refs/branch-heads/3071@{#611} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/142aaf16c7ae26acda3ef8c0072520916a390aa8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
amp
Drover merge to 59, need committer lgtm
3 years, 7 months ago (2017-05-17 20:26:12 UTC) #3
mthiesse
lgtm
3 years, 7 months ago (2017-05-17 20:26:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888973002/1
3 years, 7 months ago (2017-05-17 20:34:57 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
3 years, 7 months ago (2017-05-17 20:56:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888973002/1
3 years, 7 months ago (2017-05-17 21:08:38 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 21:12:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/142aaf16c7ae26acda3ef8c00725...

Powered by Google App Engine
This is Rietveld 408576698