Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2888933002: Adding flag descriptions for XGEO visible networks feature (Closed)

Created:
3 years, 7 months ago by lbargu
Modified:
3 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, asvitkine+watch_chromium.org, search-device-location_google.com, dougt
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding flag descriptions for XGEO visible networks feature BUG=718475 Review-Url: https://codereview.chromium.org/2888933002 Cr-Commit-Position: refs/heads/master@{#473189} Committed: https://chromium.googlesource.com/chromium/src/+/8bb0fabccc9d4581301c18ad9fdf1767b36c6d1a

Patch Set 1 #

Patch Set 2 : Adding flag descriptions for XGEO visible networks feature #

Patch Set 3 : Adding flag descriptions for XGEO visible networks feature #

Patch Set 4 : Adding flag descriptions for XGEO visible networks feature #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 3 3 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
lbargu
3 years, 7 months ago (2017-05-18 16:02:52 UTC) #9
Ted C
lgtm
3 years, 7 months ago (2017-05-18 16:09:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888933002/60001
3 years, 7 months ago (2017-05-19 14:00:14 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 14:53:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8bb0fabccc9d4581301c18ad9fdf...

Powered by Google App Engine
This is Rietveld 408576698