Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2888923002: Android: Add resources back to Android Studio (Closed)

Created:
3 years, 7 months ago by Peter Wen
Modified:
3 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, nyquist+watch_chromium.org, jbudorick+watch_chromium.org, wnwen+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Add resources back to Android Studio Resources were not collected for the pseudo all module before. Adding it back, but skipping the generated resources folders. BUG=722302 Review-Url: https://codereview.chromium.org/2888923002 Cr-Commit-Position: refs/heads/master@{#472485} Committed: https://chromium.googlesource.com/chromium/src/+/dc177240b50784d9fe81d654e129275028e6d97f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/android/gradle/generate_gradle.py View 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Peter Wen
📫
3 years, 7 months ago (2017-05-17 13:43:50 UTC) #3
agrieve
On 2017/05/17 13:43:50, Peter Wen wrote: > 📫 lgtm
3 years, 7 months ago (2017-05-17 13:45:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888923002/1
3 years, 7 months ago (2017-05-17 14:31:18 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 17:19:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc177240b50784d9fe81d654e129...

Powered by Google App Engine
This is Rietveld 408576698