[MD Bookmarks] Refine mouse selection

chrome/browser/resources/md_bookmarks/item.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'bookmarks-item',
 
   behaviors: [
     bookmarks.StoreClient,
   ],
@@ skipping 57 matching lines @@
     return this;
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onContextMenu_: function(e) {
     e.preventDefault();
     if (!this.isSelectedItem_) {
-      this.dispatch(bookmarks.actions.selectItem(
-          this.itemId, false, false, this.getState()));
+      this.dispatch(bookmarks.actions.selectItem(this.itemId, this.getState(), {

[tsergeant, 2017/05/18 23:13:37]

I think it would be nice to pull out this and the identical block in the next
method out into a helper function named something like selectThisItem_()

[calamity, 2017/05/19 06:46:56]

Done.

+        add: false,
+        range: false,
+        toggle: false,
+        updateAnchor: true,
+      }));
     }
     this.fire('open-item-menu', {
       x: e.clientX,
       y: e.clientY,
     });
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onMenuButtonClick_: function(e) {
     e.stopPropagation();
-    this.dispatch(bookmarks.actions.selectItem(
-        this.itemId, false, false, this.getState()));
+    this.dispatch(bookmarks.actions.selectItem(this.itemId, this.getState(), {
+      add: false,
+      range: false,
+      toggle: false,
+      updateAnchor: true,
+    }));
     this.fire('open-item-menu', {
       targetElement: e.target,
     });
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onMenuButtonDblClick_: function(e) {
@@ skipping 25 matching lines @@
    */
   onItemBlur_: function() {
     this.mouseFocus_ = false;
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onClick_: function(e) {
-    this.dispatch(bookmarks.actions.selectItem(
-        this.itemId, e.ctrlKey, e.shiftKey, this.getState()));
+    this.dispatch(bookmarks.actions.selectItem(this.itemId, this.getState(), {
+      add: e.ctrlKey,
+      range: e.shiftKey,
+      toggle: e.ctrlKey && !e.shiftKey,
+      updateAnchor: !e.shiftKey,
+    }));
     e.stopPropagation();
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onDblClick_: function(e) {
     if (!this.item_.url) {
       this.dispatch(
           bookmarks.actions.selectFolder(this.item_.id, this.getState().nodes));
     } else {
       chrome.tabs.create({url: this.item_.url});
     }
   },
 
   /**
    * @param {string} url
    * @private
    */
   updateFavicon_: function(url) {
     this.$.icon.style.backgroundImage = cr.icon.getFavicon(url);
   },
 });