Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2888863002: [MD Bookmarks] Refine mouse selection (Closed)

Created:
3 years, 7 months ago by calamity
Modified:
3 years, 7 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Refine mouse selection This CL makes some changes to the way multiple selection works: - single items can be selected/deselected via Ctrl+Click - Shift-Clicking doesn't update the anchor The changes made will also support keyboard navigation in a future patch. BUG=692844 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2888863002 Cr-Commit-Position: refs/heads/master@{#473508} Committed: https://chromium.googlesource.com/chromium/src/+/8e3f9e3a9823a1814f0f1f4ff3c4594abbf8a7d5

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : rebase #

Patch Set 4 : address_comments #

Patch Set 5 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -45 lines) Patch
M chrome/browser/resources/md_bookmarks/actions.js View 1 2 3 2 chunks +15 lines, -7 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/dnd_manager.js View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.js View 1 2 3 4 4 chunks +22 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/reducers.js View 1 2 3 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/actions_test.js View 1 2 3 4 chunks +27 lines, -6 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/item_test.js View 1 2 3 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/list_test.js View 1 2 3 4 chunks +85 lines, -4 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/reducers_test.js View 1 2 3 6 chunks +23 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 28 (22 generated)
calamity
3 years, 7 months ago (2017-05-18 08:32:14 UTC) #4
tsergeant
https://codereview.chromium.org/2888863002/diff/20001/chrome/browser/resources/md_bookmarks/actions.js File chrome/browser/resources/md_bookmarks/actions.js (right): https://codereview.chromium.org/2888863002/diff/20001/chrome/browser/resources/md_bookmarks/actions.js#newcode145 chrome/browser/resources/md_bookmarks/actions.js:145: * @param {{add: boolean, `add` is a confusing name ...
3 years, 7 months ago (2017-05-18 23:13:37 UTC) #8
calamity
add => clear is a doozy. https://codereview.chromium.org/2888863002/diff/20001/chrome/browser/resources/md_bookmarks/actions.js File chrome/browser/resources/md_bookmarks/actions.js (right): https://codereview.chromium.org/2888863002/diff/20001/chrome/browser/resources/md_bookmarks/actions.js#newcode145 chrome/browser/resources/md_bookmarks/actions.js:145: * @param {{add: ...
3 years, 7 months ago (2017-05-19 06:46:56 UTC) #20
tsergeant
lgtm
3 years, 7 months ago (2017-05-22 04:06:40 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888863002/140001
3 years, 7 months ago (2017-05-22 04:21:12 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 05:43:04 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/8e3f9e3a9823a1814f0f1f4ff3c4...

Powered by Google App Engine
This is Rietveld 408576698