Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2888823005: Remove duplicate service worker "register" test (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate service worker "register" test This test is identical to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage. BUG=688116, 365886 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2888823005 Cr-Commit-Position: refs/heads/master@{#473230} Committed: https://chromium.googlesource.com/chromium/src/+/97d4d455f11785e8681ad01335b9239032c658ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/serviceworker/rejections.html View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
falken
lgtm. +BUG=365886 for archaeologists.
3 years, 7 months ago (2017-05-19 03:49:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888823005/1
3 years, 7 months ago (2017-05-19 16:15:38 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 17:30:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/97d4d455f11785e8681ad01335b9...

Powered by Google App Engine
This is Rietveld 408576698