Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2888763006: Add a parser for messages with a Web Push Protocol-based payload (Closed)

Created:
3 years, 7 months ago by Peter Beverloo
Modified:
3 years, 7 months ago
Reviewers:
johnme, eroman
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a parser for messages with a Web Push Protocol-based payload This will help to avoid doing manual parsing and verification of the inbound messages in multiple places. BUG=679789 Review-Url: https://codereview.chromium.org/2888763006 Cr-Commit-Position: refs/heads/master@{#473889} Committed: https://chromium.googlesource.com/chromium/src/+/006f9034020134314605f8a64b0b3f925d1b6012

Patch Set 1 #

Total comments: 22

Patch Set 2 : Add a parser for messages with a Web Push Protocol-based payload #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -40 lines) Patch
M components/gcm_driver/crypto/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/gcm_driver/crypto/gcm_message_cryptographer_unittest.cc View 1 3 chunks +8 lines, -40 lines 0 comments Download
A components/gcm_driver/crypto/message_payload_parser.h View 1 1 chunk +85 lines, -0 lines 0 comments Download
A components/gcm_driver/crypto/message_payload_parser.cc View 1 1 chunk +65 lines, -0 lines 0 comments Download
A components/gcm_driver/crypto/message_payload_parser_unittest.cc View 1 1 chunk +103 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
Peter Beverloo
+eroman, johnme This is just generalizing parsing of the binary header. Only used in the ...
3 years, 7 months ago (2017-05-18 18:46:14 UTC) #2
johnme
lgtm with some nits/questions https://codereview.chromium.org/2888763006/diff/1/components/gcm_driver/crypto/message_payload_parser.cc File components/gcm_driver/crypto/message_payload_parser.cc (right): https://codereview.chromium.org/2888763006/diff/1/components/gcm_driver/crypto/message_payload_parser.cc#newcode17 components/gcm_driver/crypto/message_payload_parser.cc:17: constexpr size_t kUncompressedPointSize = 65; ...
3 years, 7 months ago (2017-05-22 16:18:39 UTC) #3
Peter Beverloo
Thanks! PTAL John https://codereview.chromium.org/2888763006/diff/1/components/gcm_driver/crypto/message_payload_parser.cc File components/gcm_driver/crypto/message_payload_parser.cc (right): https://codereview.chromium.org/2888763006/diff/1/components/gcm_driver/crypto/message_payload_parser.cc#newcode17 components/gcm_driver/crypto/message_payload_parser.cc:17: constexpr size_t kUncompressedPointSize = 65; On ...
3 years, 7 months ago (2017-05-22 17:25:13 UTC) #4
eroman
lgtm
3 years, 7 months ago (2017-05-22 17:46:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888763006/40001
3 years, 7 months ago (2017-05-23 14:33:11 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 14:38:12 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/006f9034020134314605f8a64b0b...

Powered by Google App Engine
This is Rietveld 408576698