Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2663)

Unified Diff: chrome/service/cloud_print/cloud_print_proxy_backend.cc

Issue 2888763004: Network traffic annotation added to CloudPrintUrlFetcher. (Closed)
Patch Set: Annotations updated. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/cloud_print_proxy_backend.cc
diff --git a/chrome/service/cloud_print/cloud_print_proxy_backend.cc b/chrome/service/cloud_print/cloud_print_proxy_backend.cc
index 6b2a8813ed85b09b83b9376142995c80ab94a100..11fc4a32bc98bc897044c42c9829ae4a0e32cb10 100644
--- a/chrome/service/cloud_print/cloud_print_proxy_backend.cc
+++ b/chrome/service/cloud_print/cloud_print_proxy_backend.cc
@@ -33,6 +33,7 @@
#include "jingle/notifier/base/notifier_options.h"
#include "jingle/notifier/listener/push_client.h"
#include "jingle/notifier/listener/push_client_observer.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
#include "url/gurl.h"
namespace cloud_print {
@@ -263,13 +264,25 @@ bool CloudPrintProxyBackend::Core::CurrentlyOnCoreThread() const {
}
void CloudPrintProxyBackend::Core::CreateAuthAndConnector() {
+ net::PartialNetworkTrafficAnnotationTag partial_traffic_annotation =
+ net::DefinePartialNetworkTrafficAnnotation("cloud_print_backend",
+ "cloud_print", R"(
+ semantics {
+ description:
+ "Creates and authenticates connection with Cloud Print."
+ trigger:
+ "Cloud Print service intialization."
msramek 2017/06/08 21:23:32 nit: Fits on one line.
Ramin Halavati 2017/06/09 04:55:46 Done.
+ data: "OAuth2 token."
+ })");
if (!auth_.get()) {
- auth_ = new CloudPrintAuth(this, settings_.server_url(), oauth_client_info_,
- settings_.proxy_id());
+ auth_ =
+ new CloudPrintAuth(this, settings_.server_url(), oauth_client_info_,
+ settings_.proxy_id(), partial_traffic_annotation);
}
if (!connector_.get()) {
- connector_ = new CloudPrintConnector(this, settings_);
+ connector_ =
+ new CloudPrintConnector(this, settings_, partial_traffic_annotation);
}
}

Powered by Google App Engine
This is Rietveld 408576698